From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbbC3Xif (ORCPT ); Mon, 30 Mar 2015 19:38:35 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41339 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbbC3Xic (ORCPT ); Mon, 30 Mar 2015 19:38:32 -0400 X-AuditID: cbfee68e-f79b46d000002b74-5c-5519de764ae5 Message-id: <5519DE76.4080803@samsung.com> Date: Tue, 31 Mar 2015 08:38:30 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Kukjin Kim , Alessandro Zummo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, Alexandre Belloni , Kyungmin Park Subject: Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkULfsnmSowemNahZLLl5lt+i4tpjJ Yv6Rc6wWr18YWvQ/fs1scbbpDbvFpsfXWC0u75rDZjHj/D4mi/2dHYwOXB5PNl1k9Ngz8SSb x6ZVnWwem5fUe/RtWcXoMX3eTyaPz5vkAtijuGxSUnMyy1KL9O0SuDLmHT3DXjBNpKJj9lum BsalAl2MnBwSAiYSn34fYIWwxSQu3FvP1sXIxSEksJRRYvuW+SwwRbfb/7JDJBYxSly8MYMV wnnAKNF2cgs7SBWvgJbEnMOrwDpYBFQllk+fA2azAcX3v7jBBmKLCoRJrJx+hQWiXlDix+R7 YLaIgKHEwd3bmUCGMgvcYJJYdXEi2E3CAuESDUdWgy0QEmhllPixwg7E5hTwkLi77jVYnFlA R2J/6zQ2CFteYvOat8wQZ39kl3jVYAlxkIDEt8mHgJZxAMVlJTYdgCqRlDi44gbLBEaxWUhO moVk6iwkUxcwMq9iFE0tSC4oTkovMtIrTswtLs1L10vOz93ECIzT0/+e9e1gvHnA+hCjAAej Eg9vxR3JUCHWxLLiytxDjKZAV0xklhJNzgcmg7ySeENjMyMLUxNTYyNzSzMlcd4EqZ/BQgLp iSWp2ampBalF8UWlOanFhxiZODilGhiVtAI2fozmUr9tZSDdGnm66bHuqh/s0y9a/6vb0ZP4 QfZDwutXl1eEW9VPWX76BzfzWYPceo6DtUYv5kdddf+lVhIqtim3X29h45PDBgpNB76WKV72 fb+jmPW8ofBd5ntz9n8oy1TyTvXQ9uXw9FgVdO+9YbkWx/UF7+u/6cb+6i9ettuBp0eJpTgj 0VCLuag4EQCwUxZNzgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xgG7ZPclQg2XbFCyWXLzKbtFxbTGT xfwj51gtXr8wtOh//JrZ4mzTG3aLTY+vsVpc3jWHzWLG+X1MFvs7OxgduDyebLrI6LFn4kk2 j02rOtk8Ni+p9+jbsorRY/q8n0wenzfJBbBHNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5ua GRjqGlpamCsp5CXmptoqufgE6Lpl5gCdp6RQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQI rsfIAA0krGHMmHf0DHvBNJGKjtlvmRoYlwp0MXJySAiYSNxu/8sOYYtJXLi3nq2LkYtDSGAR o8TFGzNYIZwHjBJtJ7eAVfEKaEnMObyKBcRmEVCVWD59DpjNBhTf/+IGG4gtKhAmsXL6FRaI ekGJH5PvgdkiAoYSB3dvZwIZyixwg0li1cWJrCAJYYFwiYYjq8EWCAm0Mkr8WGEHYnMKeEjc XfcaLM4soCOxv3UaG4QtL7F5zVvmCYwCs5DsmIWkbBaSsgWMzKsYRVMLkguKk9JzDfWKE3OL S/PS9ZLzczcxgtPAM6kdjCsbLA4xCnAwKvHwOtZLhAqxJpYVV+YeYpTgYFYS4fXcKhkqxJuS WFmVWpQfX1Sak1p8iNEUGAQTmaVEk/OBKSqvJN7Q2MTMyNLI3NDCyNhcSZxXyb4tREggPbEk NTs1tSC1CKaPiYNTqoHR59qM+NlPdH7mrROf/CtwD2OVQ1z53Lz9J/cn7JA2dnC2Ct9udnXm djfTE90CjHOWRb5YdoLt/jqrnaeNjwfsauE4v2KzRuLpJdkqt1ftvqS2ynfF/XfdDJqfmAM9 pEKmaCv/+dp5Rn2DZFDBZtXVknf2vmrhMLKa1sl/NnTuZqXUHlfudaLflViKMxINtZiLihMB 7JxUZRkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote: > Mark "samsung,exynos3250-rtc" compatible as deprecated because it > duplicates the "samsung,s3c6410-rtc". Use "samsung,s3c6410-rtc" on > Exynos3250 and Exynos4415 boards. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 3 ++- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos4415.dtsi | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > index ab757b84daa7..ac2fcd6ff4b8 100644 > --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > @@ -6,7 +6,8 @@ Required properties: > * "samsung,s3c2416-rtc" - for controllers compatible with s3c2416 rtc. > * "samsung,s3c2443-rtc" - for controllers compatible with s3c2443 rtc. > * "samsung,s3c6410-rtc" - for controllers compatible with s3c6410 rtc. > - * "samsung,exynos3250-rtc" - for controllers compatible with exynos3250 rtc. > + * "samsung,exynos3250-rtc" - (deprecated) for controllers compatible with > + exynos3250 rtc (use "samsung,s3c6410-rtc"). > - reg: physical base address of the controller and length of memory mapped > region. > - interrupts: Two interrupt numbers to the cpu should be specified. First > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index e3bfb11c6ef8..8d58b550e925 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -189,7 +189,7 @@ > }; > > rtc: rtc@10070000 { > - compatible = "samsung,exynos3250-rtc"; > + compatible = "samsung,s3c6410-rtc"; > reg = <0x10070000 0x100>; > interrupts = <0 73 0>, <0 74 0>; > interrupt-parent = <&pmu_system_controller>; > diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi > index 5caea996e090..186cb8465683 100644 > --- a/arch/arm/boot/dts/exynos4415.dtsi > +++ b/arch/arm/boot/dts/exynos4415.dtsi > @@ -177,7 +177,7 @@ > }; > > rtc: rtc@10070000 { > - compatible = "samsung,exynos3250-rtc"; > + compatible = "samsung,s3c6410-rtc"; > reg = <0x10070000 0x100>; > interrupts = <0 73 0>, <0 74 0>; > status = "disabled"; > Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi