From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbbCaAAB (ORCPT ); Mon, 30 Mar 2015 20:00:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37483 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276AbbC3X76 (ORCPT ); Mon, 30 Mar 2015 19:59:58 -0400 Message-ID: <5519E37C.9010201@codeaurora.org> Date: Mon, 30 Mar 2015 16:59:56 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andrew Bresticker , Mike Turquette , Ralf Baechle CC: devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Ezequiel Garcia , James Hartley , James Hogan Subject: Re: [PATCH 2/7] clk: Add basic infrastructure for Pistachio clocks References: <1424836567-7252-1-git-send-email-abrestic@chromium.org> <1424836567-7252-3-git-send-email-abrestic@chromium.org> In-Reply-To: <1424836567-7252-3-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/15 19:56, Andrew Bresticker wrote: > + > +void pistachio_clk_force_enable(struct pistachio_clk_provider *p, > + unsigned int *clk_ids, unsigned int num) > +{ > + unsigned int i; > + int err; > + > + for (i = 0; i < num; i++) { > + struct clk *clk = p->clk_data.clks[clk_ids[i]]; > + > + if (IS_ERR(clk)) > + continue; > + > + err = clk_prepare_enable(clk); > + if (err) > + pr_err("Failed to enable clock %s: %d\n", > + __clk_get_name(clk), err); > + } > +} > Is this to workaround some problems in the framework where clocks are turned off? Or is it that these clocks are already on before we boot Linux and we need to make sure the framework knows that? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project