From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbbCaAr1 (ORCPT ); Mon, 30 Mar 2015 20:47:27 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:20333 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbbCaArY (ORCPT ); Mon, 30 Mar 2015 20:47:24 -0400 X-AuditID: cbfee68f-f791c6d000004834-ee-5519ee94bb5a Message-id: <5519EE93.70509@samsung.com> Date: Tue, 31 Mar 2015 09:47:15 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Alexandre Belloni Cc: Krzysztof Kozlowski , Kukjin Kim , Alessandro Zummo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, Kyungmin Park Subject: Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> <5519DE76.4080803@samsung.com> <20150331003101.GG3849@piout.net> In-reply-to: <20150331003101.GG3849@piout.net> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsWyRsSkWHfKO8lQg3vfRSyWXLzKbtFxbTGT xfwj51gtXr8wtOh//JrZ4mzTG3aLTY+vsVpc3jWHzWLG+X1MFvs7OxgduDyebLrI6LFn4kk2 j02rOtk8Ni+p9+jbsorRY/q8n0wenzfJBbBHcdmkpOZklqUW6dslcGUc+LSApeCYeMW2tT9Y GxhbhLsYOTkkBEwkfnx+yAhhi0lcuLeerYuRi0NIYCmjxNltR5hhijaugElMZ5Q4+uUGE4Tz gFFiy+JDrCBVvAIaEse6l7CB2CwCqhLzH3cygdhsAloS+1/cAIuLCoRJrJx+hQWiXlDix+R7 YLaIgI1E5867YBuYBU4zSbx4sRRstbBAuETDkdXsILaQwAlGiSetNiA2p4CexINn/WBDmQV0 JPa3ToOy5SU2r3nLDDJIQuAtu8TWA1eYIC4SkPg2+RDQNg6ghKzEpgNQr0lKHFxxg2UCo9gs JDfNQjJ2FpKxCxiZVzGKphYkFxQnpRcZ6xUn5haX5qXrJefnbmIERurpf8/6dzDePWB9iFGA g1GJh7fijmSoEGtiWXFl7iFGU6ArJjJLiSbnA9NBXkm8obGZkYWpiamxkbmlmZI470Kpn8FC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGBPEo1dOS3gb09a/edq3rI/PC8ynXlzicNdhjdD9 R+tdQnMENB78KVeSXFEiZaO1mDfmwlyWS3PNWy5ePyVyQK9eVmPjcp7VfLXyhWIuTwpm6J55 zTe58c3vZM22fS1OndNtjl8SzGmYUCL5m3m21OmmqNv7tpild7xYukDW3n1y9OvI9qsCLUos xRmJhlrMRcWJAERRQgTPAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xoO6Ud5KhBvcm81gsuXiV3aLj2mIm i/lHzrFavH5haNH/+DWzxdmmN+wWmx5fY7W4vGsOm8WM8/uYLPZ3djA6cHk82XSR0WPPxJNs HptWdbJ5bF5S79G3ZRWjx/R5P5k8Pm+SC2CPamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1 MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAE6T0mhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQ XI+RARpIWMOYceDTApaCY+IV29b+YG1gbBHuYuTkkBAwkdi4Yj0bhC0mceEeiM3FISQwnVHi 6JcbTBDOA0aJLYsPsYJU8QpoSBzrXgLWwSKgKjH/cScTiM0moCWx/8UNsLioQJjEyulXWCDq BSV+TL4HZosI2Eh07rwLtoFZ4DSTxIsXS5lBEsIC4RINR1azg9hCAicYJZ602oDYnAJ6Eg+e 9YMNZRbQkdjfOg3KlpfYvOYt8wRGgVlIdsxCUjYLSdkCRuZVjKKpBckFxUnpuYZ6xYm5xaV5 6XrJ+bmbGMFp4JnUDsaVDRaHGAU4GJV4eC/ckwwVYk0sK67MPcQowcGsJMLruRUoxJuSWFmV WpQfX1Sak1p8iNEUGAQTmaVEk/OBKSqvJN7Q2MTMyNLI3NDCyNhcSZxXyb4tREggPbEkNTs1 tSC1CKaPiYNTqoFRUmap3R55/rxph+M2TfG4lZh8lbXt4YHATKn5lSHVCjLb4r1bDHUm7+Bs K3josLngk3NwgIzj9zMmq5ze5/VIJ6rysfbfa1Tb1b3Yeb4E90enxTteL0s/Yxf8o3lB1Fe/ Xzz2IZwx6fWTmp/W/OPOVDl7xPOT3rLLwoxGHB/uPH9rnbb9kZQSS3FGoqEWc1FxIgAx7War GQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/31/2015 09:31 AM, Alexandre Belloni wrote: > Hi, > > On 31/03/2015 at 08:38:30 +0900, Chanwoo Choi wrote : >>> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >>> index ab757b84daa7..ac2fcd6ff4b8 100644 >>> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >>> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >>> @@ -6,7 +6,8 @@ Required properties: >>> * "samsung,s3c2416-rtc" - for controllers compatible with s3c2416 rtc. >>> * "samsung,s3c2443-rtc" - for controllers compatible with s3c2443 rtc. >>> * "samsung,s3c6410-rtc" - for controllers compatible with s3c6410 rtc. >>> - * "samsung,exynos3250-rtc" - for controllers compatible with exynos3250 rtc. >>> + * "samsung,exynos3250-rtc" - (deprecated) for controllers compatible with >>> + exynos3250 rtc (use "samsung,s3c6410-rtc"). >>> - reg: physical base address of the controller and length of memory mapped >>> region. >>> - interrupts: Two interrupt numbers to the cpu should be specified. First >>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>> index e3bfb11c6ef8..8d58b550e925 100644 >>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>> @@ -189,7 +189,7 @@ >>> }; >>> >>> rtc: rtc@10070000 { >>> - compatible = "samsung,exynos3250-rtc"; >>> + compatible = "samsung,s3c6410-rtc"; >>> reg = <0x10070000 0x100>; >>> interrupts = <0 73 0>, <0 74 0>; >>> interrupt-parent = <&pmu_system_controller>; >>> diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi >>> index 5caea996e090..186cb8465683 100644 >>> --- a/arch/arm/boot/dts/exynos4415.dtsi >>> +++ b/arch/arm/boot/dts/exynos4415.dtsi >>> @@ -177,7 +177,7 @@ >>> }; >>> >>> rtc: rtc@10070000 { >>> - compatible = "samsung,exynos3250-rtc"; >>> + compatible = "samsung,s3c6410-rtc"; >>> reg = <0x10070000 0x100>; >>> interrupts = <0 73 0>, <0 74 0>; >>> status = "disabled"; >>> >> >> Looks good to me. >> >> Reviewed-by: Chanwoo Choi >> > > Are you absolutely sure that the exynos3250 IP is the same as the > s3c6410 (I don't know much about the exynos family). The concern being > that if at one point you have an errata on one or ther other, you will > have to break the DT ABI by undoing this change. > > Note that I'm fine with it, I'm just asking. I'm sure about exynos3250 RTC is same with S3C6410 RTC. There was little different about that pevious S3C6410 RTC don't consider to control the 'rtc_src' clk. But, Javier's patch[1] add the '.needs_src_clk' to control the 'rtc_src' clk. After merged this patch, there is no different part between Exynos3250 RTC and S3C6410 RTC. [1] 8792f7772f4f (drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data) Thanks, Chanwoo Choi