From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbbCaBmw (ORCPT ); Mon, 30 Mar 2015 21:42:52 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:57790 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969AbbCaBmu (ORCPT ); Mon, 30 Mar 2015 21:42:50 -0400 Message-ID: <5519FB90.4010400@huawei.com> Date: Tue, 31 Mar 2015 09:42:40 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Al Stone , Hanjun Guo , "Will Deacon" , Catalin Marinas CC: , "Rafael J. Wysocki" , , , Subject: Re: [Linaro-acpi] [PATCH 1/2] ARM64 / ACPI: Ignore the return error value of acpi_map_gic_cpu_interface() References: <1427458476-20140-1-git-send-email-hanjun.guo@linaro.org> <5519C5C8.2020903@linaro.org> In-Reply-To: <5519C5C8.2020903@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/31 5:53, Al Stone wrote: > On 03/27/2015 06:14 AM, Hanjun Guo wrote: >> MADT table scannig will stopped once it gets the errors >> returned by the handler, which is acpi_map_gic_cpu_interface() >> in for ARM64, so Ignore the return error value to search for >> all enabled CPUs for SMP init. > I think the comment should say something like: > > MADT scanning will stop when it gets an error from the handler, > acpi_map_gic_cpu_interface(), on arm64. However, we need to > find all of the enabled CPUs so that SMP initialization can work > properly. So, if an error occurs in this case, ignore it for > now so that we can find all of the enabled CPUs. > > Is that what you meant, Hanjun? That's exactly what I mean, you describe it much clearer :) Thanks Hanjun