From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751040AbbCaEGG (ORCPT ); Tue, 31 Mar 2015 00:06:06 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:57899 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbbCaEGB (ORCPT ); Tue, 31 Mar 2015 00:06:01 -0400 X-AuditID: cbfee691-f79b86d000004a5a-ad-551a1d28dedd Message-id: <551A1D27.6000301@samsung.com> Date: Tue, 31 Mar 2015 13:05:59 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Markus Reichl Subject: Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id References: <1427728889-29158-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1427728889-29158-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWyRsSkRFdDVirU4HyXhMX8I+dYLV6/MLTo f/ya2eJs0xt2i02Pr7FaXN41h81ixvl9TBYvj/xgtFh75C67A6fHrTv1HptWdbJ5bF5S79G3 ZRWjx+dNcgGsUVw2Kak5mWWpRfp2CVwZJ+b1Mhf85KxY+uoNWwPjTI4uRk4OCQETiZd37jFB 2GISF+6tZ+ti5OIQEljKKNG1r58RpmjG0b8sEInpjBL3Jm5kh3AeMErMe9zNDFLFK6AlcX/T dzYQm0VAVWLewsfsIDYbUHz/ixtgcVGBMImV06+wQNQLSvyYfA/MFhEwlDi4ezsTyFBmgTVM Et8PLQdrFhawk5h9YS9YkZCAu8SKl5vBbuUU8JBY1XEPbDGzgI7E/tZpbBC2vMTmNW+ZQQZJ CNxil9g5cQ8zxEUCEt8mHwIaxAGUkJXYdIAZ4jVJiYMrbrBMYBSbheSmWUjGzkIydgEj8ypG 0dSC5ILipPQiU73ixNzi0rx0veT83E2MwEg8/e/ZxB2M9w9YH2IU4GBU4uGtuCMZKsSaWFZc mXuI0RToionMUqLJ+cB4zyuJNzQ2M7IwNTE1NjK3NFMS59WR/hksJJCeWJKanZpakFoUX1Sa k1p8iJGJg1OqgXGKGavalSvS81Nm3DII/J5T6yNxaEuBRtympS+T11pyTH+9siPizmXBx2Ue L94aLvqs+P3vloWnZKuFup7MvfUr4d/fLc3Cde2fJjN3MK5fcWjhRrGnR9Zu8UsqvjT3+K2e yiefzTNfmkW5vmK67PLhZ9YU7xaTZ6seKgrdVCm96z3jlcnOlsU9SizFGYmGWsxFxYkASPXU 4r8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jQV0NWalQg5dLBC3mHznHavH6haFF /+PXzBZnm96wW2x6fI3V4vKuOWwWM87vY7J4eeQHo8XaI3fZHTg9bt2p99i0qpPNY/OSeo++ LasYPT5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLx CdB1y8wBOkdJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmHFiXi9zwU/O iqWv3rA1MM7k6GLk5JAQMJGYcfQvC4QtJnHh3nq2LkYuDiGB6YwS9yZuZIdwHjBKzHvczQxS xSugJXF/03c2EJtFQFVi3sLH7CA2G1B8/4sbYHFRgTCJldOvsEDUC0r8mHwPzBYRMJQ4uHs7 E8hQZoE1TBLfDy0HaxYWsJOYfWEvWJGQgLvEipebmUBsTgEPiVUd98AWMwvoSOxvncYGYctL bF7zlnkCo8AsJDtmISmbhaRsASPzKkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzgOH8mvYNx VYPFIUYBDkYlHt6KO5KhQqyJZcWVuYcYJTiYlUR493wECvGmJFZWpRblxxeV5qQWH2I0BQbB RGYp0eR8YArKK4k3NDYxM7I0Mje0MDI2VxLnVbJvCxESSE8sSc1OTS1ILYLpY+LglGpgFOrh kVnEKvH6mmQUn0q3tcWpcw+euIcoTfF/+3TNc6ttF3xrxZY3P+TIe3pAz2X9xnP6D4JePrA4 81Bq0w7t1cs/fDtstVj2e+uVf4ffredlzzFr/cA+lZ+p6u+eR89W5H0yc9uUbibSJbtl5o/6 NfEXXsu53zfnVBO+Z6o1MXab2T+hpJe3dymxFGckGmoxFxUnAgB162zACQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote: > Use a define instead of raw number as a ID for "rtc_src" clock. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from: > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 3905824cac58..d2cbc95364de 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -16,6 +16,7 @@ > #include "exynos3250.dtsi" > #include > #include > +#include > > / { > model = "Samsung Rinato board"; > @@ -605,7 +606,7 @@ > }; > > &rtc { > - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>; > + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>; > clock-names = "rtc", "rtc_src"; > status = "okay"; > }; > Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi