From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbbCaFGh (ORCPT ); Tue, 31 Mar 2015 01:06:37 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:18019 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750706AbbCaFGc (ORCPT ); Tue, 31 Mar 2015 01:06:32 -0400 X-AuditID: cbfee68e-f79b46d000002b74-55-551a2b55e97d Message-id: <551A2B55.7000500@samsung.com> Date: Tue, 31 Mar 2015 14:06:29 +0900 From: Jaewon Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Kishon Vijay Abraham I Cc: Vivek Gautam , Kamil Debski , Kukjin Kim , Vivek Gautam , Inki Dae , Chanwoo Choi , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Linux USB Mailing List Subject: Re: [PATCH RESEND] phy: exynos5-usbdrd: Add to support for Exynos5433 SoC References: <1427336323-10515-1-git-send-email-jaewon02.kim@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsWyRsSkUDdUWyrUYP53XYvrX56zWrRdOchu 8fb7FnaLSfcnsFj8eH2BzaL/8WtmiwtPe9gsLu+aw2Yx4/w+JotFy1qZHbg8ds66y+6xaVUn m0ffllWMHsdvbGfy+LxJLoA1issmJTUnsyy1SN8ugStj984tjAUnlSsONyxnaWD8KNXFyMkh IWAiMaNpCSuELSZx4d56ti5GLg4hgaWMEkef7maDKepauZwdIjGdUaLp2U9GCOcBo8SGnlPs IFW8AloSh273gY1iEVCVOL7wFCOIzSagLfF9/WKgOAeHqECExO3LnBDlghI/Jt9jAbFFgFpP 7/zBDDKTWWAFs8SBnavAeoUFQiRuX/oCdVI/o8TNtr1gCU6BYIkzPw8wg9jMAmYSX14eZoWw 5SU2r3kLNklC4BG7xN5zd9ghLhKQ+Db5EAvIFRICshKbIHolBCQlDq64wTKBUWwWkqNmIRk7 C8nYBYzMqxhFUwuSC4qT0ouM9IoTc4tL89L1kvNzNzECI/P0v2d9OxhvHrA+xCjAwajEw1tx RzJUiDWxrLgy9xCjKdAVE5mlRJPzgfGfVxJvaGxmZGFqYmpsZG5ppiTOmyD1M1hIID2xJDU7 NbUgtSi+qDQntfgQIxMHp1QDo4msYbfQYc1ikxvV2suydx66oarJHjufa/WHoMRilwPH7iu2 /lh2s/U9+5L/OQvVt0QtCzkwacbExI+bZa2nc35/Lt3+Lu2A2a8Ntw/NqXvV8VkzrVX8xPJX /YtOTe4Uv2bbk5Ob81RKueiI0FaWPSw5B/ceP++zalud2NaLKzm51S8IP4sLYVFiKc5INNRi LipOBADcG7aqxwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jQd1QbalQg70rVS2uf3nOatF25SC7 xdvvW9gtJt2fwGLx4/UFNov+x6+ZLS487WGzuLxrDpvFjPP7mCwWLWtlduDy2DnrLrvHplWd bB59W1Yxehy/sZ3J4/MmuQDWqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3Ml hbzE3FRbJRefAF23zBygs5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWM Gbt3bmEsOKlccbhhOUsD40epLkZODgkBE4mulcvZIWwxiQv31rN1MXJxCAlMZ5RoevaTEcJ5 wCixoecUWBWvgJbEodt9rCA2i4CqxPGFpxhBbDYBbYnv6xcDxTk4RAUiJG5f5oQoF5T4Mfke C4gtAtR6eucPZpCZzAIrmCUO7FwF1issECJx+9IXqM39jBI32/aCJTgFgiXO/DzADGIzC5hJ fHl5mBXClpfYvOYt8wRGgVlIlsxCUjYLSdkCRuZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmb GMFx/0xqB+PKBotDjAIcjEo8vBfuSYYKsSaWFVfmHmKU4GBWEuHd8xEoxJuSWFmVWpQfX1Sa k1p8iNEUGAQTmaVEk/OBKSmvJN7Q2MTMyNLI3NDCyNhcSZxXyb4tREggPbEkNTs1tSC1CKaP iYNTqoGR9+CvnUXXUqJLtC2TPhumRE2PV3a6XbVZQue71ubPvQfdXPxLJofYeplw+8zt5OXs 8ntre15H9iRX2JcfTAlCJ76+lf6yjXeDy+F0Sbm8P7V9k0Ust1++vGbugeu/bdf6RLYeu9jN //nhLDP9+yueXuNM3/k1Y/Yn/hoZPyWVaSKGky6t37JAiaU4I9FQi7moOBEAFKaqNBEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon. Could you check my patch?? On 26/03/2015 14:16, Vivek Gautam wrote: > On Thu, Mar 26, 2015 at 7:48 AM, Jaewon Kim wrote: >> This patch adds driver data to support for Exynos5433 SoC. >> The Exynos5433 has one USB3.0 Host and USB3.0 DRD(Dual Role Device). >> Exynos5433 is simplar to Eyxnos7 but Exynos5433 have >> one more USB3.0 Host controller. >> >> Signed-off-by: Jaewon Kim >> Tested-by: Chanwoo Choi >> --- > Patch looks good to me. > > Reviewed-by: Vivek Gautam > >> .../devicetree/bindings/phy/samsung-phy.txt | 3 ++- >> drivers/phy/phy-exynos5-usbdrd.c | 10 ++++++++++ >> include/linux/mfd/syscon/exynos5-pmu.h | 3 +++ >> 3 files changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 91e38cf..60c6f2a 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> @@ -128,6 +128,7 @@ Required properties: >> - compatible : Should be set to one of the following supported values: >> - "samsung,exynos5250-usbdrd-phy" - for exynos5250 SoC, >> - "samsung,exynos5420-usbdrd-phy" - for exynos5420 SoC. >> + - "samsung,exynos5433-usbdrd-phy" - for exynos5433 SoC. >> - "samsung,exynos7-usbdrd-phy" - for exynos7 SoC. >> - reg : Register offset and length of USB DRD PHY register set; >> - clocks: Clock IDs array as required by the controller >> @@ -139,7 +140,7 @@ Required properties: >> PHY operations, associated by phy name. It is used to >> determine bit values for clock settings register. >> For Exynos5420 this is given as 'sclk_usbphy30' in CMU. >> - - optional clocks: Exynos7 SoC has now following additional >> + - optional clocks: Exynos5433 & Exynos7 SoC has now following additional >> gate clocks available: >> - phy_pipe: for PIPE3 phy >> - phy_utmi: for UTMI+ phy >> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c >> index e2a0be7..d72ef15 100644 >> --- a/drivers/phy/phy-exynos5-usbdrd.c >> +++ b/drivers/phy/phy-exynos5-usbdrd.c >> @@ -624,6 +624,13 @@ static const struct exynos5_usbdrd_phy_drvdata exynos5250_usbdrd_phy = { >> .has_common_clk_gate = true, >> }; >> >> +static const struct exynos5_usbdrd_phy_drvdata exynos5433_usbdrd_phy = { >> + .phy_cfg = phy_cfg_exynos5, >> + .pmu_offset_usbdrd0_phy = EXYNOS5_USBDRD_PHY_CONTROL, >> + .pmu_offset_usbdrd1_phy = EXYNOS5433_USBHOST30_PHY_CONTROL, >> + .has_common_clk_gate = false, >> +}; >> + >> static const struct exynos5_usbdrd_phy_drvdata exynos7_usbdrd_phy = { >> .phy_cfg = phy_cfg_exynos5, >> .pmu_offset_usbdrd0_phy = EXYNOS5_USBDRD_PHY_CONTROL, >> @@ -638,6 +645,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { >> .compatible = "samsung,exynos5420-usbdrd-phy", >> .data = &exynos5420_usbdrd_phy >> }, { >> + .compatible = "samsung,exynos5433-usbdrd-phy", >> + .data = &exynos5433_usbdrd_phy >> + }, { >> .compatible = "samsung,exynos7-usbdrd-phy", >> .data = &exynos7_usbdrd_phy >> }, >> diff --git a/include/linux/mfd/syscon/exynos5-pmu.h b/include/linux/mfd/syscon/exynos5-pmu.h >> index 00ef24b..9352adc 100644 >> --- a/include/linux/mfd/syscon/exynos5-pmu.h >> +++ b/include/linux/mfd/syscon/exynos5-pmu.h >> @@ -36,6 +36,9 @@ >> #define EXYNOS5420_MTCADC_PHY_CONTROL (0x724) >> #define EXYNOS5420_DPTX_PHY_CONTROL (0x728) >> >> +/* Exynos5433 specific register definitions */ >> +#define EXYNOS5433_USBHOST30_PHY_CONTROL (0x728) >> + >> #define EXYNOS5_PHY_ENABLE BIT(0) >> >> #define EXYNOS5_MIPI_PHY_S_RESETN BIT(1) >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Thanks, Jaewon Kim.