From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbbCaHLO (ORCPT ); Tue, 31 Mar 2015 03:11:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49432 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbbCaHLK (ORCPT ); Tue, 31 Mar 2015 03:11:10 -0400 Message-ID: <551A488B.3060206@redhat.com> Date: Tue, 31 Mar 2015 09:11:07 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Benjamin Tissoires , Dmitry Torokhov , Henrik Rydberg , Peter Hutterer CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Balanced slots, attempt #2 References: <1427753368-2795-1-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1427753368-2795-1-git-send-email-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 31-03-15 00:09, Benjamin Tissoires wrote: > Hi, > > So, it occurs that the balanced slots assignment introduced in v4.0 had some > troubles and the Synaptics part was reverted. > I tried to spend some time today to figure out a solution, and the only way > I can get something from it is to add a band aid in input_mt_set_slots(). > > It should not be very costly, but I think it is required: I can guarantee that > the path is hit if the band aid is not here (pr_err was my friend). > > So the series is: > - band aid > - revert the revert > - small fix in synaptics.c to keep the slots stable when landing a third finger. > > Cheers, > Benjamin The entire set looks good to me: Acked-by: Hans de Goede Regards, Hans