From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966AbbCaOtZ (ORCPT ); Tue, 31 Mar 2015 10:49:25 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55822 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbbCaOtW (ORCPT ); Tue, 31 Mar 2015 10:49:22 -0400 Message-ID: <551AB37D.1090104@ti.com> Date: Tue, 31 Mar 2015 17:47:25 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: , , , , , , , , , Subject: Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available References: <1427459213-14611-1-git-send-email-peter.ujfalusi@ti.com> <1427459213-14611-6-git-send-email-peter.ujfalusi@ti.com> <20150327202446.GB4027@n2100.arm.linux.org.uk> In-Reply-To: <20150327202446.GB4027@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote: > On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote: >> + if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node, >> + "dma-requests", >> + &od->dma_requests)) { >> + dev_info(&pdev->dev, >> + "Missing dma-requests property, using %u.\n", >> + OMAP_SDMA_REQUESTS); >> + od->dma_requests = OMAP_SDMA_REQUESTS; >> + } > > Are all OMAPs including OMAP1 being converted to DT? If not, don't > introduce noisy printks for which a platform can't do anything about. > Think about this please - if there's no of_node, then why complain > about a missing OF property? Yes, you are perfectly right on this. Will fix it up. Thanks, Péter