From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754345AbbCaP1b (ORCPT ); Tue, 31 Mar 2015 11:27:31 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:50009 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753362AbbCaP13 (ORCPT ); Tue, 31 Mar 2015 11:27:29 -0400 Message-ID: <551ABCBE.3030005@ti.com> Date: Tue, 31 Mar 2015 20:56:54 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Baruch Siach , Marek Vasut CC: , , Subject: Re: [PATCH 2/2] phy: driver for Conexant Digicolor internal USB PHY References: <6284a7672647d46100281959552f9787f98bb552.1427430989.git.baruch@tkos.co.il> <4a9ceb0a240d49dd6a68d50c78f85d310d4b932f.1427430989.git.baruch@tkos.co.il> <201503281633.02801.marex@denx.de> <20150331113448.GN12479@tarshish> In-Reply-To: <20150331113448.GN12479@tarshish> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 31 March 2015 05:04 PM, Baruch Siach wrote: > Hi Marek, > > On Sat, Mar 28, 2015 at 04:33:02PM +0100, Marek Vasut wrote: >> On Friday, March 27, 2015 at 05:36:29 AM, Baruch Siach wrote: >>> Add a driver for the USB PHY on the Conexant CX92755 SoC, from the >>> Digicolor series of SoCs. The PHY is connected to the on-chip chipidea >>> usb2 host. >>> >>> The hardware is somewhat similar to the phy-mxs-usb.c usb_phy, but it is >>> different enough to merit its own driver. Also, this driver uses the >>> generic phy infrastructure. >> >> the register set looks very similar to MXS one indeed. How is it different >> please ? > > Almost of the bits that are defined in the MXS USBPHY_CTRL register are not > defined in the Digicolor one. Some have different meaning, and some are > reserved. OTOH, the Digicolor USBPHY_CTRL register uses all bits in the 1-13 > range. Also, the Digicolor phy does not have anatop registers. I think we should try adding support for this in the same driver. Thanks Kishon