From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755193AbbCaQJO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 12:09:14 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:53900 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754648AbbCaQJL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 12:09:11 -0400
Message-ID: <551AC69E.3050407@ti.com>
Date: Tue, 31 Mar 2015 21:39:02 +0530
From: Kishon Vijay Abraham I <kishon@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Axel Lin <axel.lin@ingics.com>
CC: Pratyush Anand <pratyush.anand@st.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate
References: <1427274093.2613.0.camel@phoenix>
In-Reply-To: <1427274093.2613.0.camel@phoenix>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wednesday 25 March 2015 02:31 PM, Axel Lin wrote:
> The of_xlate callback should return ERR_PTR on error.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/phy/phy-spear1310-miphy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
> index 9f47fae..4684b04 100644
> --- a/drivers/phy/phy-spear1310-miphy.c
> +++ b/drivers/phy/phy-spear1310-miphy.c
> @@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
>
>   	if (args->args_count < 1) {
>   		dev_err(dev, "DT did not pass correct no of args\n");
> -		return NULL;
> +		return ERR_PTR(-EINVAL);

It should actually be -ENODEV so that phy_optional_get() doesn't fail.
>   	}
>
>   	priv->mode = args->args[0];
>
>   	if (priv->mode != SATA && priv->mode != PCIE) {
>   		dev_err(dev, "DT did not pass correct phy mode\n");
> -		return NULL;
> +		return ERR_PTR(-EINVAL);

Same here.

Thanks
Kishon