From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbbCaQRb (ORCPT ); Tue, 31 Mar 2015 12:17:31 -0400 Received: from lists.s-osg.org ([54.187.51.154]:55793 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036AbbCaQR0 (ORCPT ); Tue, 31 Mar 2015 12:17:26 -0400 Message-ID: <551AC894.40101@osg.samsung.com> Date: Tue, 31 Mar 2015 10:17:24 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt , Michael Ellerman CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, namhyung@kernel.org Subject: Re: [PATCH] ftracetest: Cope properly with stack tracer not being enabled References: <1427692900-11191-1-git-send-email-mpe@ellerman.id.au> <20150330173633.64c53cb9@gandalf.local.home> In-Reply-To: <20150330173633.64c53cb9@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2015 03:36 PM, Steven Rostedt wrote: > On Mon, 30 Mar 2015 16:21:40 +1100 > Michael Ellerman wrote: > >> If the stack tracer (CONFIG_STACK_TRACER) is disabled, the >> fgraph-filter-stack test blows chunks: >> >> [8] ftrace - function graph filters with stack tracer [FAIL] >> + reset_tracer >> + echo nop >> ./ftracetest: 19: /home/michael/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc: >> cannot create /proc/sys/kernel/stack_tracer_enabled: Directory nonexistent >> >> Fix it by checking if the proc file exists before echoing to it. With >> the patch applied it fails correctly with: >> >> [8] ftrace - function graph filters with stack tracer [UNSUPPORTED] >> >> Signed-off-by: Michael Ellerman >> --- > > Acked-by: Steven Rostedt > Applied to linux-kselftest next for 4.1 thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978