From: Shuah Khan <shuahkh@osg.samsung.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
namhyung@kernel.org
Subject: Re: [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL
Date: Tue, 31 Mar 2015 10:17:54 -0600 [thread overview]
Message-ID: <551AC8B2.4080001@osg.samsung.com> (raw)
In-Reply-To: <20150330155050.4715e9fb@gandalf.local.home>
On 03/30/2015 01:50 PM, Steven Rostedt wrote:
> On Mon, 30 Mar 2015 16:21:00 +1100
> Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> POSIX says that exit takes an unsigned integer between 0 and 255, so
>> using -1 doesn't work on POSIX shells.
>>
>> There is already a well-defined failure code, $FAIL (1), so use that.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
Applied to linux-kselftest next for 4.1
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
prev parent reply other threads:[~2015-03-31 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 5:21 [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL Michael Ellerman
2015-03-30 19:50 ` Steven Rostedt
2015-03-31 16:17 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AC8B2.4080001@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox