From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755156AbbCaQnM (ORCPT ); Tue, 31 Mar 2015 12:43:12 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:33244 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754519AbbCaQnJ (ORCPT ); Tue, 31 Mar 2015 12:43:09 -0400 Message-ID: <551ACE9B.5050608@kernel.dk> Date: Tue, 31 Mar 2015 10:43:07 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dmitry Monakhov , linux-kernel@vger.kernel.org CC: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, dm-devel@redhat.com Subject: Re: [RFC] [PATCH 0/7] fs: add blkdev name format specifier References: <1427817681-4494-1-git-send-email-dmonakhov@openvz.org> In-Reply-To: <1427817681-4494-1-git-send-email-dmonakhov@openvz.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2015 10:01 AM, Dmitry Monakhov wrote: > Currently in order to print block_device name one should use blkdev() helper > which requires temproral buffer of size BDEVNAME_SIZE (32bytes). This is very > ineffective because result in stack usage bloating for deep IO call traces where > stack usage is close to maximum values. > > It is reasonable to introduce dedicated format specifier for block_device name, > unfortunately "%pb", "%pB", "%pd" and "%pD" are already reserved for other data types > I've pick "%pg" ala geometry. If some one want to offer sane spacifier name > please let me know. > > Since this is RFC version I've pick rough patch split policy (based on subsystem). > Please let me know if patchset should be split in different way. I think this is looks good, nice improvement. I can take the lib and block parts, Al can pick up the fs bits. -- Jens Axboe