From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753289AbbCaW0L (ORCPT ); Tue, 31 Mar 2015 18:26:11 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:38553 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbbCaW0H (ORCPT ); Tue, 31 Mar 2015 18:26:07 -0400 Message-ID: <551B1EFC.305@gmail.com> Date: Tue, 31 Mar 2015 16:26:04 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Yunlong Song , a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH 3/9] perf sched replay: Alloc the memory of pid_to_task dynamically to adapt to the unexpected change of pid_max References: <1427809596-29559-1-git-send-email-yunlong.song@huawei.com> <1427809596-29559-4-git-send-email-yunlong.song@huawei.com> <551AB005.8080102@gmail.com> <20150331202515.GO9438@kernel.org> In-Reply-To: <20150331202515.GO9438@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/31/15 2:25 PM, Arnaldo Carvalho de Melo wrote: > > Humm, we already have an rb_tree for each task, its called > machine->threads, and it has struct thread instances, that in turn have > a ->priv point, can't it be used here? > I think that would require a lot of churn to the existing code. The command could definitely use some modernizing, but it will take time. David