From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbbDAJUk (ORCPT ); Wed, 1 Apr 2015 05:20:40 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35626 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbbDAJUf (ORCPT ); Wed, 1 Apr 2015 05:20:35 -0400 Message-ID: <551BB85F.7060102@gmail.com> Date: Wed, 01 Apr 2015 12:20:31 +0300 From: Xenia Ragiadakou User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Steven Rostedt , LKML CC: Christian Borntraeger , Cornelia Huck , David Hildenbrand , Marcelo Tosatti , Sarah Sharp , Mark Brown Subject: Re: [RFC][PATCH] tracing: Replace '-' with '_' in event system names References: <20150331231802.23527931@grimm.local.home> In-Reply-To: <20150331231802.23527931@grimm.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2015 06:18 πμ, Steven Rostedt wrote: > There's a change I want to make to the tracing infrastructure that may > require TRACE_SYSTEM be a valid variable name. As '-' can not be used > in a variable, and I found only three cases that it is a TRACE_SYSTEM > name, I want to ask those that are responsible if it is OK to change > them? > > The three systems are: > > #define TRACE_SYSTEM kvm-s390 > #define TRACE_SYSTEM xhci-hcd > #define TRACE_SYSTEM intel-sst > > > I want to replace the '-' with '_'. But this will have a user space > visible affect, which is why I'm inquiring with you. If this will break > any scripts or annoy any users that you know of, I'll need to make a > work around (which would not be hard to do). But if I don't need to do > that, I prefer to just use TRACE_SYSTEM as is. > > I'll just do the work around if there is any user space tool that you > know of that will break with this change. > > The effect is that the directories in /sys/kernel/debug/tracing/events/ > will be different. That is, > > /sys/kernel/debug/tracing/events/kvm-s390/ > > will become > > /sys/kernel/debug/tracing/events/kvm_s390/ > > And the same for the other two. Is this a problem? > > Thanks! > > -- Steve > > Tentatively-signed-off-by: Steven Rostedt > --- > arch/s390/kvm/trace-s390.h | 2 +- > drivers/usb/host/xhci-trace.h | 2 +- > include/trace/events/intel-sst.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/s390/kvm/trace-s390.h b/arch/s390/kvm/trace-s390.h > index 653a7ec09ef5..bf02effdf535 100644 > --- a/arch/s390/kvm/trace-s390.h > +++ b/arch/s390/kvm/trace-s390.h > @@ -4,7 +4,7 @@ > #include > > #undef TRACE_SYSTEM > -#define TRACE_SYSTEM kvm-s390 > +#define TRACE_SYSTEM kvm_s390 > #define TRACE_INCLUDE_PATH . > #undef TRACE_INCLUDE_FILE > #define TRACE_INCLUDE_FILE trace-s390 > diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h > index dde3959b7a33..b610374b6f36 100644 > --- a/drivers/usb/host/xhci-trace.h > +++ b/drivers/usb/host/xhci-trace.h > @@ -12,7 +12,7 @@ > */ > > #undef TRACE_SYSTEM > -#define TRACE_SYSTEM xhci-hcd > +#define TRACE_SYSTEM xhci_hcd > > #if !defined(__XHCI_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) > #define __XHCI_TRACE_H > diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h > index 76c72d3f1902..11bb4ca0fac7 100644 > --- a/include/trace/events/intel-sst.h > +++ b/include/trace/events/intel-sst.h > @@ -1,5 +1,5 @@ > #undef TRACE_SYSTEM > -#define TRACE_SYSTEM intel-sst > +#define TRACE_SYSTEM intel_sst > > #if !defined(_TRACE_INTEL_SST_H) || defined(TRACE_HEADER_MULTI_READ) > #define _TRACE_INTEL_SST_H > The change affects the trace-cmd plugin for xhci, but I can fix that, no problem. regards, Xenia