Re: [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code.

Jiri Olsa
2015-04-01T12:19:11Z

On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote:
> Create a machine_map_new() and merge mapping code in
> machine__process_mmap2_event() and machine__process_mmap_event()
> together. This patch is a preparation for following map adjustment
> patches.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
> tools/perf/util/machine.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index e335330..051883a 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1155,13 +1155,29 @@ out_problem:
> return -1;
> }
>
> +static int machine_map_new(struct machine *machine, u64 start, u64 len,
> + u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino,
> + u64 ino_gen, u32 prot, u32 flags, char *filename,
> + enum map_type type, struct thread *thread)

the name style for this should be more like 'machine__new_map'
I think Arnaldo will chime in.. ;-)

jirka