From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbbDBJSt (ORCPT ); Thu, 2 Apr 2015 05:18:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:37092 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbbDBJSp (ORCPT ); Thu, 2 Apr 2015 05:18:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,509,1422950400"; d="scan'208";a="689381664" Message-ID: <551D08F8.3040706@intel.com> Date: Thu, 02 Apr 2015 12:16:40 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo , Jiri Olsa CC: linux-kernel@vger.kernel.org, David Ahern , Borislav Petkov , Don Zickus , Frederic Weisbecker , Namhyung Kim , Stephane Eranian Subject: Re: [RFC 0/2] perf scripting cleanups References: <1427906210-10519-1-git-send-email-acme@kernel.org> In-Reply-To: <1427906210-10519-1-git-send-email-acme@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: > Hi David, Jiri, > > Please take a look if it is ok for you guys > > Adrian, there is another thing: > > db_export__sample(&tables->dbe, event, sample, evsel, al->thread, al); > > In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy > as well, see the (al->thread, al), I'll probably remove that extra thread parm Yes please remove it too. > there if you don't have any other subtle use for that... Nope > > - Arnaldo > > Arnaldo Carvalho de Melo (2): > perf script: No need to lookup thread twice > perf scripting: No need to pass thread twice to the scripting > callbacks > > tools/perf/builtin-script.c | 14 +++----------- > tools/perf/util/scripting-engines/trace-event-perl.c | 5 ++--- > tools/perf/util/scripting-engines/trace-event-python.c | 13 +++++-------- > tools/perf/util/trace-event-scripting.c | 1 - > tools/perf/util/trace-event.h | 3 +-- > 5 files changed, 11 insertions(+), 25 deletions(-) >