From: Shuah Khan <shuahkh@osg.samsung.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: "Namhyung Kim" <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Pádraig Brady" <P@draigBrady.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Dave Jones" <davej@codemonkey.org.uk>,
"Luis Henriques" <luis.henriques@canonical.com>,
"Shuah Khan" <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly
Date: Thu, 02 Apr 2015 08:20:09 -0600 [thread overview]
Message-ID: <551D5019.9010806@osg.samsung.com> (raw)
In-Reply-To: <20150402093827.617192f0@gandalf.local.home>
On 04/02/2015 07:38 AM, Steven Rostedt wrote:
> On Thu, 02 Apr 2015 14:58:04 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> (2015/04/02 13:34), Namhyung Kim wrote:
>>> The usleep is only provided on distros from Redhat so running ftracetest
>>> on other distro resulted in failures due to the missing usleep.
>>>
>>> The reason of using [u]sleep in the test was to generate (scheduler)
>>> events. It can be done various ways like this:
>>>
>>> yield() { ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; }
>>
>> Nice hack! :)
>
> Yep, it was Pádraig Brady's idea.
>
>>
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> -- Steve
>
>>
>>>
>>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>>> Reported-by: Dave Jones <davej@codemonkey.org.uk>
>>> Reported-by: Luis Henriques <luis.henriques@canonical.com>
>>> Based-on-patch-by: Pádraig Brady <P@draigBrady.com>
Is this standard? checkpatch complained as non-standard. I am
seeing some patches posted with Based-on-patch-by
Anyway, I have this patch tagged for 4.1-rc2
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-04-02 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 4:24 [PATCH v2] ftracetest: Do not use usleep directly Namhyung Kim
2015-04-02 4:34 ` [PATCH v2.1] " Namhyung Kim
2015-04-02 5:58 ` Masami Hiramatsu
2015-04-02 13:38 ` Steven Rostedt
2015-04-02 14:20 ` Shuah Khan [this message]
2015-04-02 15:08 ` Steven Rostedt
2015-04-02 16:30 ` Shuah Khan
2015-04-02 16:48 ` Steven Rostedt
2015-04-02 16:52 ` Shuah Khan
2015-04-02 17:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551D5019.9010806@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=P@draigBrady.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox