From: Rik van Riel <riel@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dave Jones <davej@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/3] context_tracking: Protect against recursion
Date: Thu, 02 Apr 2015 14:01:01 -0400 [thread overview]
Message-ID: <551D83DD.5010200@redhat.com> (raw)
In-Reply-To: <1427996365-12101-2-git-send-email-fweisbec@gmail.com>
On 04/02/2015 01:39 PM, Frederic Weisbecker wrote:
> Context tracking recursion can happen when an exception triggers in the
> middle of a call to a context tracking probe.
>
> This special case can be caused by vmalloc faults. If an access to a
> memory area allocated by vmalloc happens in the middle of
> context_tracking_enter(), we may run into an endless fault loop because
> the exception in turn calls context_tracking_enter() which faults on
> the same vmalloc'ed memory, triggering an exception again, etc...
>
> Some rare crashes have been reported so lets protect against this with
> a recursion counter.
>
> Reported-by: Dave Jones <davej@redhat.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Dave Jones <davej@redhat.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2015-04-02 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 17:39 [PATCH 0/3] context_tracking: A few improvements Frederic Weisbecker
2015-04-02 17:39 ` [PATCH 1/3] context_tracking: Protect against recursion Frederic Weisbecker
2015-04-02 18:01 ` Rik van Riel [this message]
2015-04-02 17:39 ` [PATCH 2/3] context_tracking: Inherit TIF_NOHZ through forks instead of context switches Frederic Weisbecker
2015-04-02 18:06 ` Rik van Riel
2015-04-02 18:08 ` Oleg Nesterov
2015-04-03 17:19 ` Frederic Weisbecker
2015-04-02 19:09 ` Peter Zijlstra
2015-04-02 19:11 ` Rik van Riel
2015-04-03 17:21 ` Frederic Weisbecker
2015-04-02 19:19 ` Oleg Nesterov
2015-04-02 17:39 ` [PATCH 3/3] context_tracking: Tag init code Frederic Weisbecker
2015-04-02 18:07 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551D83DD.5010200@redhat.com \
--to=riel@redhat.com \
--cc=davej@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox