From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbbDBWAm (ORCPT ); Thu, 2 Apr 2015 18:00:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbbDBWAk (ORCPT ); Thu, 2 Apr 2015 18:00:40 -0400 Message-ID: <551DBC05.2090301@codeaurora.org> Date: Thu, 02 Apr 2015 15:00:37 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bjorn Andersson , Andy Gross , Ian Campbell , Kumar Gala , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , Rob Herring , Srinivas Kandagatla CC: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device References: <1427928946-31291-1-git-send-email-bjorn.andersson@sonymobile.com> In-Reply-To: <1427928946-31291-1-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/15 15:55, Bjorn Andersson wrote: > Stephen Boyd pointed out that the current design of the Qualcomm RPM and > regulator driver consumes 12-20kB of ram just for the platform_device structs. > > This series starts with a new revision of the dt binding documentation for the > rpm regulators, introduces the regulator-allow-drms property, remove the > flagging of DRMS support from the qcom-rpm regulator driver, refactor the > qcom_rpm-regulator driver to move all custom parse code to a function suitable > for usage as of_parse_cb. The final patch defines the tables of registers and > change the probe function to register the appropriate regulators based on pmic. > > As Stephen pointed out in his PATCH/RFC/argument [1], this gives a more > accurate representation of input supplies, as they are now named as in the > specification. > > Note that for platforms with multiple pmics (e.g. 8660 and 8974) will have > multiple regulator subnodes to the rpm node - something that will be clearer > with this binding than the previously suggested. What happens with debugfs when you have multiple pmics with the same named regulator? I thought that in this case we needed to make the names unique somehow or we would end up with the same directory for two different regulators. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project