From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbbDBXov (ORCPT ); Thu, 2 Apr 2015 19:44:51 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:12674 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbbDBXor (ORCPT ); Thu, 2 Apr 2015 19:44:47 -0400 X-AuditID: cbfee68d-f79296d000004278-e4-551dd46df700 Message-id: <551DD46C.6030207@samsung.com> Date: Fri, 03 Apr 2015 08:44:44 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check References: <1427985116-20314-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1427985116-20314-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWyRsSkSDf3imyowenbPBZLLl5lt+i4tpjJ 4vULQ4vLu+awWcw4v4/JYu2Ru+wW+zs7GB3YPZ5susjosWfiSTaPvi2rGD2mz/vJ5PF5k1wA axSXTUpqTmZZapG+XQJXxtu561gLOjgqlm7rZGxgPMfWxcjBISFgIvFlgmQXIyeQKSZx4d56 oDAXh5DAUkaJl5efsEIkTCT2LWhmhkgsYpSY9e4/O4TzgFFiy+kpjCBVvAJaEvsapjCB2CwC qhLP1q4B62YDiu9/cYMNxBYVCJNYOf0KC0S9oMSPyffAbBEBQ4mDu7czgQxlFvjKKDHl9hqw QcICfhIrP3WALRAScJe4tmM/2CBOAQ+JlpW72EFsZgEdif2t09ggbHmJzWvegp0qIXCKXeLF 5vPsEBcJSHybfIgF4mdZiU0HmCFek5Q4uOIGywRGsVlIbpqFZOwsJGMXMDKvYhRNLUguKE5K LzLUK07MLS7NS9dLzs/dxAiMu9P/nvXuYLx9wPoQowAHoxIPb8YemVAh1sSy4srcQ4ymQFdM ZJYSTc4HRndeSbyhsZmRhamJqbGRuaWZkjivotTPYCGB9MSS1OzU1ILUovii0pzU4kOMTByc Ug2McrO/H9LekT/TwXTDpMUHc+LYexlnOEZYck21ma9/9HbPQb6A0Bf/p9+R+u+3677d04xl 1xfEre2Ur3q1bPvP3P/fuLfcsBAQvDrpzJscw8lfWbjtn30Q0C//X+xXtt+NMUAkgIXrbPxt pviJDzkvv0sNlpxd43T6KTObyJ7LX+Q6lRhtJhm/UGIpzkg01GIuKk4EAMODS8G2AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAd3cK7KhBn++slgsuXiV3aLj2mIm i9cvDC0u75rDZjHj/D4mi7VH7rJb7O/sYHRg93iy6SKjx56JJ9k8+rasYvSYPu8nk8fnTXIB rFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDPezl3HWtDBUbF0WydjA+M5 ti5GTg4JAROJfQuamSFsMYkL99YDxbk4hAQWMUrMevefHcJ5wCix5fQURpAqXgEtiX0NU5hA bBYBVYlna9ewgthsQPH9L26ATRUVCJNYOf0KC0S9oMSPyffAbBEBQ4mDu7czgQxlFvjKKDHl 9hqwQcICfhIrP3WALRAScJe4tmM/2CBOAQ+JlpW72EFsZgEdif2t09ggbHmJzWveMk9gFJiF ZMcsJGWzkJQtYGRexSiaWpBcUJyUnmukV5yYW1yal66XnJ+7iREc18+kdzCuarA4xCjAwajE w5uxRyZUiDWxrLgy9xCjBAezkgjvit2yoUK8KYmVValF+fFFpTmpxYcYTYFBMJFZSjQ5H5hy 8kriDY1NzIwsjcwNLYyMzZXEeZXs20KEBNITS1KzU1MLUotg+pg4OKUaGENc9zd6LJoxbc+7 VD353/xu1w48sMhzWLl9U/NeMbvCTczyCnk11q8Obm8prexUFFdPPH+uYa6d7+fEA+YhT8/y vYuxsJlXUD0r5MqCKUsXVu3sdUnfH1te+XnKZI03dW1r63e0CV+f3W6gI1g5tTLuorzI7doQ li0L90jzK3LN7rypZVUio8RSnJFoqMVcVJwIAF+GG6UBAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2015 11:31 PM, Krzysztof Kozlowski wrote: > The s3c_rtc_gettime() returns already result of rtc_valid_tm() on > obtained time so get rid of another call to rtc_valid_tm(). > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/rtc/rtc-s3c.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index 1d3a4c58fec4..a0f832362199 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 1); > > /* Check RTC Time */ > - s3c_rtc_gettime(&pdev->dev, &rtc_tm); > - > - if (rtc_valid_tm(&rtc_tm)) { > + if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) { > rtc_tm.tm_year = 100; > rtc_tm.tm_mon = 0; > rtc_tm.tm_mday = 1; > s3c_rtc_gettime() return the value of rtc_valid_tm(). Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi