From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222AbbDFKqs (ORCPT ); Mon, 6 Apr 2015 06:46:48 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:61793 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbbDFKqn (ORCPT ); Mon, 6 Apr 2015 06:46:43 -0400 X-AuditID: cbfee68e-f79c56d000006efb-fe-552264113dda Message-id: <55226411.2060806@samsung.com> Date: Mon, 06 Apr 2015 19:46:41 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Jaehoon Chung , Seungwon Jeon , Ulf Hansson Cc: Alim Akhtar , Sonny Rao , Andrew Bresticker , Heiko Stuebner , Addy Ke , Alexandru Stan , javier.martinez@collabora.co.uk, linux-rockchip@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mmc: dw_mmc: Increase cmd11 timeout to 500ms References: <1428084787-8710-1-git-send-email-dianders@chromium.org> In-reply-to: <1428084787-8710-1-git-send-email-dianders@chromium.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWyRsSkSFcwRSnUYN1hLYuV7/8yWiz7/53J 4sG8bWwWDS8msVqcXXaQzeL/o9esFkd/F1jc+NXGanF51xw2iyP/+xktPj34z2zx5MxMRosP 9y8yWxxfG+7A5zG74SKLx9/n11k87lzbw+axeUm9x99Z+1k8+rasYvTYfm0es8fnTXIBHFFc NimpOZllqUX6dglcGS2XVjMXfOCtuDphBUsD40euLkZODgkBE4lNl8+xQthiEhfurWcDsYUE ljJKNJ9xgKn5O28PUxcjF1B8EaPEus6J7BDOA0aJ4/+msYNU8QpoSZw7cgNsEouAqsT/a1PB bDYBHYnt344zgdiiAmESE28+ZoWoF5T4MfkeC4gtIrCQUeJZTyjIUGaB50wSk+5NAGsQFnCV eA4MHoiTXCQmrVoD1MzBwQkUf/eeDcRkFtCTuH9RC6SCWUBeYvOat8wgYyQEZnJILLo9lx3i HgGJb5MPsYDUSwjISmw6wAzxmKTEwRU3WCYwis1CctEshKmzkExdwMi8ilE0tSC5oDgpvchI rzgxt7g0L10vOT93EyMwok//e9a3g/HmAetDjAIcjEo8vB7PFEOFWBPLiitzDzGaAh0xkVlK NDkfmDbySuINjc2MLExNTI2NzC3NlMR5E6R+BgsJpCeWpGanphakFsUXleakFh9iZOLglGpg VOj+d9tJvs7+65ljvrkHl82c9efzww0cbIsNkhf8zWBYXT7HP0nv75z1xe/UfWe9bnjw4diJ zw65i8zdZZh37Zp0bVEWb+M7IZYzFnm3/fe+jGuzn7pn9rqfNxK7Ltmcm7E5tbZYWX7hSp2V RZsbTz/wr3qZcEdJUGG/3VS2ErPn5bPLo1fqNSmxFGckGmoxFxUnAgCUPARf4wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jAV3BFKVQgxVbFC1Wvv/LaLHs/3cm iwfztrFZNLyYxGpxdtlBNov/j16zWhz9XWBx41cbq8XlXXPYLI7872e0+PTgP7PFkzMzGS0+ 3L/IbHF8bbgDn8fshossHn+fX2fxuHNtD5vH5iX1Hn9n7Wfx6NuyitFj+7V5zB6fN8kFcEQ1 MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAJ2tpFCW mFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcxoubSaueADb8XVCStYGhg/cnUx cnJICJhI/J23hwnCFpO4cG89WxcjF4eQwCJGiXWdE9khnAeMEsf/TWMHqeIV0JI4d+QGK4jN IqAq8f/aVDCbTUBHYvu342CTRAXCJCbefMwKUS8o8WPyPRYQW0RgIaPEs55QkKHMAs+ZJCbd mwDWICzgKvEcGPwgtpCAi8SkVWuAmjk4OIHi796zgZjMAnoS9y9qgVQwC8hLbF7zlnkCo8As JBtmIVTNQlK1gJF5FaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZwwngmtYNxZYPFIUYBDkYl Ht4FLxRDhVgTy4orcw8xSnAwK4nwbo9QChXiTUmsrEotyo8vKs1JLT7EaAr0/0RmKdHkfGAy yyuJNzQ2MTOyNDI3tDAyNlcS552jKxcqJJCeWJKanZpakFoE08fEwSnVwLj//vSe6r0cJc0p F2otWNhltbOuecXv9N/ptyn1O7/qh1NHWKv66z1EpmwtCXEomizCGXz95NKHfrOnG5ueS1jD dLFEoeRA1SS11GUiYmrKs2ft+nJ3e4TKuQMljlyfNiV/D2B+3s+1IeyixfG+r7M0Njhcr/Ux f3Fof6uE57XmVxEnjj9/36bEUpyRaKjFXFScCAAkqt5sLgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Doug. On 04/04/2015 03:13 AM, Doug Anderson wrote: > The Designware databook claims that cmd11 should be finished in 2ms, > but my testing showed that not to be the case in some situations. > I've seen cmd11 timeouts of up to 130ms (!) during reboot tests. > Let's bump the timeout way up so that we're absolutely sure. CMD11 is > only sent during card insertion, so this extra timeout shouldn't be > terrible. Is it h/w problem? Could you explain to me about "some situations"? As you said, this timeout only used during card inserting. So, it's not critical.. But there is much different between 2ms and 500ms(or 130ms). Best Regards, Jaehoon Chung > > Fixes: 5c935165da79 ("mmc: dw_mmc: Add a timeout for sending CMD11") > Signed-off-by: Doug Anderson > --- > drivers/mmc/host/dw_mmc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 3883fe6..339a929 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1023,11 +1023,13 @@ static void __dw_mci_start_request(struct dw_mci *host, > > if (cmd->opcode == SD_SWITCH_VOLTAGE) { > /* > - * Databook says to fail after 2ms w/ no response; give an > - * extra jiffy just in case we're about to roll over. > + * Databook says to fail after 2ms w/ no response, but evidence > + * shows that sometimes the cmd11 interrupt takes over 130ms. > + * We'll set to 500ms, plus an extra jiffy just in case jiffies > + * is just about to roll over. > */ > mod_timer(&host->cmd11_timer, > - jiffies + msecs_to_jiffies(2) + 1); > + jiffies + msecs_to_jiffies(500) + 1); > } > > if (mrq->stop) >