From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbbDFPyf (ORCPT ); Mon, 6 Apr 2015 11:54:35 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:35446 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbbDFPyc (ORCPT ); Mon, 6 Apr 2015 11:54:32 -0400 Message-ID: <5522AC36.6010504@kernel.dk> Date: Mon, 06 Apr 2015 09:54:30 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: nimisolo CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: remove unnecessary check in blk_mq_alloc_tag_set References: <1428295474-15585-1-git-send-email-nimisolo@aliyun.com> In-Reply-To: <1428295474-15585-1-git-send-email-nimisolo@aliyun.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2015 10:44 PM, nimisolo wrote: > already check set->nr_hw_queues above : > if (!set->nr_hw_queues) > return -EINVAL; > > Signed-off-by: nimisolo > --- > block/blk-mq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index b7b8933..3ae21c4 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -2161,7 +2161,7 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set) > if (set->queue_depth < set->reserved_tags + BLK_MQ_TAG_MIN) > return -EINVAL; > > - if (!set->nr_hw_queues || !set->ops->queue_rq || !set->ops->map_queue) > + if (!set->ops->queue_rq || !set->ops->map_queue) > return -EINVAL; > > if (set->queue_depth > BLK_MQ_MAX_DEPTH) { This is already fixed in for-4.1/core. -- Jens Axboe