From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbDFP4Z (ORCPT ); Mon, 6 Apr 2015 11:56:25 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:33817 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbbDFP4E (ORCPT ); Mon, 6 Apr 2015 11:56:04 -0400 Message-ID: <5522AC91.4070802@kernel.dk> Date: Mon, 06 Apr 2015 09:56:01 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: nimisolo CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: remove unused param in bt_alloc() References: <1428312991-26657-1-git-send-email-nimisolo@aliyun.com> In-Reply-To: <1428312991-26657-1-git-send-email-nimisolo@aliyun.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2015 03:36 AM, nimisolo wrote: > In bt_alloc(), the param is unused, maybe we can remove it. Should probably turn that into WARN() condition instead, of depth == 0 and !reserved. -- Jens Axboe