From: Bert Vermeulen <bert@biot.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-mips@linux-mips.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards
Date: Tue, 07 Apr 2015 00:49:24 +0200 [thread overview]
Message-ID: <55230D74.3000003@biot.com> (raw)
In-Reply-To: <CAHp75VfeY80hu9kZWJ1KPos7gzTgV53OT-X67MJWT2h8nGSjqw@mail.gmail.com>
Hi Andy,
I will submit a new version with your comments addressed. However this one:
On 04/06/2015 12:13 PM, Andy Shevchenko wrote:
>> +static struct spi_driver rb4xx_cpld_driver = {
>> + .probe = rb4xx_cpld_probe,
>> + .remove = rb4xx_cpld_remove,
>> + .driver = {
>> + .name = "rb4xx-cpld",
>> + .bus = &spi_bus_type,
>> + .owner = THIS_MODULE,
>
> Do we really need this line?
>
> + },
> +};
> +
> +module_spi_driver(rb4xx_cpld_driver);
Yes, apparently. It's only the module_platform_driver() macro that
automatically fills in the owner field. All SPI protocol drivers do this
(except one, video/backlight/hx8357.c). Having said that, I don't really get
what that field is used for.
--
Bert Vermeulen bert@biot.com email/xmpp
next prev parent reply other threads:[~2015-04-06 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 1:51 [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards Bert Vermeulen
2015-04-06 7:27 ` Paul Bolle
2015-04-06 10:13 ` Andy Shevchenko
2015-04-06 22:49 ` Bert Vermeulen [this message]
2015-04-07 6:52 ` Lee Jones
2015-04-07 15:48 ` Bert Vermeulen
2015-04-07 16:31 ` Andy Shevchenko
2015-07-28 12:51 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55230D74.3000003@biot.com \
--to=bert@biot.com \
--cc=andy.shevchenko@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox