From: Xishi Qiu <qiuxishi@huawei.com>
To: Dave Young <dyoung@redhat.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<tglx@linutronix.de>, <bhe@redhat.com>,
<akpm@linux-foundation.org>, <isimatu.yasuaki@jp.fujitsu.com>,
<mingo@redhat.com>, <hpa@zytor.com>
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix
Date: Wed, 8 Apr 2015 09:59:04 +0800 [thread overview]
Message-ID: <55248B68.7000308@huawei.com> (raw)
In-Reply-To: <20150408014630.GF7213@localhost.localdomain>
On 2015/4/8 9:46, Dave Young wrote:
>>>
>>> - /* Mark all kernel nodes. */
>>> + /*
>>> + * Mark all kernel nodes.
>>> + *
>>> + * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
>>
>> Hi Dave,
>>
>> It should both set mem=xx and numa=off, then numa_meminfo may not include all
>> the memblock.reserved memory, right?
>
> Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> possiblity that it may happen even without numa=off. Just consider the non-snb board..
>
> Thanks
> Dave
>
Hi Dave,
I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
is right.
Reviewed-by: Xishi Qiu <qiuxishi@huawei.com>
> .
>
next prev parent reply other threads:[~2015-04-08 2:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 13:41 [PATCH V2] x86/numa: kernel stack corruption fix Dave Young
2015-04-07 14:09 ` [tip:x86/urgent] x86/mm/numa: Fix kernel stack corruption in numa_init()-> numa_clear_kernel_node_hotplug() tip-bot for Dave Young
2015-04-08 1:36 ` [PATCH V2] x86/numa: kernel stack corruption fix Xishi Qiu
2015-04-08 1:46 ` Dave Young
2015-04-08 1:59 ` Xishi Qiu [this message]
2015-04-08 2:18 ` Baoquan He
2015-04-08 2:41 ` Xishi Qiu
2015-04-08 3:09 ` Dave Young
2015-04-09 3:27 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55248B68.7000308@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox