* [PATCH -tip] perf probe: fix ARM 32 building error.
@ 2015-04-08 2:14 Wang Nan
2015-04-08 2:36 ` Masami Hiramatsu
2015-04-08 15:14 ` [tip:perf/core] perf probe: Fix " tip-bot for Wang Nan
0 siblings, 2 replies; 3+ messages in thread
From: Wang Nan @ 2015-04-08 2:14 UTC (permalink / raw)
To: acme, jolsa, namhyung, mingo, masami.hiramatsu.pt
Cc: lizefan, pi3orama, linux-kernel
Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
handle aliased symbols in glibc") uses an absolute format '%lx' to
print u64 argument, which causes compiling error on ARM 32.
This patch replaces it with PRIx64.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
---
tools/perf/util/probe-event.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 8feac07..3dacec9 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
ret = -ENOENT;
goto out;
}
- pr_debug("Symbol %s address found : %lx\n", pp->function, address);
+ pr_debug("Symbol %s address found : %" PRIx64 "\n",
+ pp->function, address);
ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
result);
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -tip] perf probe: fix ARM 32 building error.
2015-04-08 2:14 [PATCH -tip] perf probe: fix ARM 32 building error Wang Nan
@ 2015-04-08 2:36 ` Masami Hiramatsu
2015-04-08 15:14 ` [tip:perf/core] perf probe: Fix " tip-bot for Wang Nan
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2015-04-08 2:36 UTC (permalink / raw)
To: Wang Nan; +Cc: acme, jolsa, namhyung, mingo, lizefan, pi3orama, linux-kernel
(2015/04/08 11:14), Wang Nan wrote:
> Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
> handle aliased symbols in glibc") uses an absolute format '%lx' to
> print u64 argument, which causes compiling error on ARM 32.
>
> This patch replaces it with PRIx64.
Good catch! :)
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
> tools/perf/util/probe-event.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 8feac07..3dacec9 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
> ret = -ENOENT;
> goto out;
> }
> - pr_debug("Symbol %s address found : %lx\n", pp->function, address);
> + pr_debug("Symbol %s address found : %" PRIx64 "\n",
> + pp->function, address);
>
> ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
> result);
>
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/core] perf probe: Fix ARM 32 building error
2015-04-08 2:14 [PATCH -tip] perf probe: fix ARM 32 building error Wang Nan
2015-04-08 2:36 ` Masami Hiramatsu
@ 2015-04-08 15:14 ` tip-bot for Wang Nan
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Wang Nan @ 2015-04-08 15:14 UTC (permalink / raw)
To: linux-tip-commits
Cc: namhyung, jolsa, acme, wangnan0, masami.hiramatsu.pt, lizefan,
mingo, hpa, linux-kernel, tglx
Commit-ID: f6c15621f04b97ce882c66e5055f0ac325fb8eb8
Gitweb: http://git.kernel.org/tip/f6c15621f04b97ce882c66e5055f0ac325fb8eb8
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Wed, 8 Apr 2015 02:14:34 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 8 Apr 2015 10:49:48 -0300
perf probe: Fix ARM 32 building error
Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to
handle aliased symbols in glibc") uses an absolute format '%lx' to
print u64 argument, which causes compiling error on ARM 32.
This patch replaces it with PRIx64.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1428459274-138470-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 4fd49f0..b788517 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -322,7 +322,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
ret = -ENOENT;
goto out;
}
- pr_debug("Symbol %s address found : %lx\n", pp->function, address);
+ pr_debug("Symbol %s address found : %" PRIx64 "\n",
+ pp->function, address);
ret = debuginfo__find_probe_point(dinfo, (unsigned long)address,
result);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-08 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 2:14 [PATCH -tip] perf probe: fix ARM 32 building error Wang Nan
2015-04-08 2:36 ` Masami Hiramatsu
2015-04-08 15:14 ` [tip:perf/core] perf probe: Fix " tip-bot for Wang Nan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox