From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753760AbbDHNIS (ORCPT ); Wed, 8 Apr 2015 09:08:18 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60862 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbbDHNIP (ORCPT ); Wed, 8 Apr 2015 09:08:15 -0400 Message-ID: <55252836.5050703@roeck-us.net> Date: Wed, 08 Apr 2015 06:08:06 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Max Filippov CC: Chris Zankel , "linux-xtensa@linux-xtensa.org" , LKML , Ard Biesheuvel , Arnd Bergmann Subject: Re: [PATCH -next] xtensa: Fix fix linker script transformation for .text / .text.fixup References: <1428472194-28665-1-git-send-email-linux@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.5525283E.033D,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2015 11:14 PM, Max Filippov wrote: > Hi Guenter, > > On Wed, Apr 8, 2015 at 8:49 AM, Guenter Roeck wrote: >> Commit 779c88c94c34 ("ARM: 8321/1: asm-generic: introduce .text.fixup >> input section") introduced a new .text.fixup section which is merged >> with .text at link time. This causes xtensa builds to fail with lots >> of error messages similar to the following. >> >> lib/lib.a(kobject.o): In function `kobject_create': >> (.text+0x498): dangerous relocation: l32r: literal placed after use: >> (.literal+0x150) >> >> Linker script transformation needs to be updated to detect and handle >> the new section. > > I've posted a patch for it to the linux-xtensa ML a while ago: > http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20150330/001913.html > >> Fixes: 779c88c94c34 ("ARM: 8321/1: asm-generic: introduce .text.fixup >> input section") >> Cc: Ard Biesheuvel >> Cc: Arnd Bergmann >> Signed-off-by: Guenter Roeck >> --- >> arch/xtensa/kernel/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/xtensa/kernel/Makefile b/arch/xtensa/kernel/Makefile >> index 18d962a..d3a0f0f 100644 >> --- a/arch/xtensa/kernel/Makefile >> +++ b/arch/xtensa/kernel/Makefile >> @@ -29,6 +29,7 @@ AFLAGS_head.o += -mtext-section-literals >> >> sed-y = -e 's/\*(\(\.[a-z]*it\|\.ref\|\)\.text)/*(\1.literal \1.text)/g' \ >> -e 's/\.text\.unlikely/.literal.unlikely .text.unlikely/g' \ >> + -e 's/\*(\(\.text .*\))/*(.literal \1)/g' \ > > This doesn't handle literals for .text.fixup AFAICT. > It doesn't, but then it wasn't supposed to. .text.fixup is arm specific. Guenter