From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932278AbbDHSZ4 (ORCPT ); Wed, 8 Apr 2015 14:25:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49805 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbbDHSZy (ORCPT ); Wed, 8 Apr 2015 14:25:54 -0400 Message-ID: <552572B0.2090207@codeaurora.org> Date: Wed, 08 Apr 2015 11:25:52 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Julia Lawall , Mike Turquette , Linus Walleij CC: kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 1/2] clk: versatile: test returned value References: <1428159570-19467-1-git-send-email-Julia.Lawall@lip6.fr> <1428159570-19467-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1428159570-19467-2-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/15 07:59, Julia Lawall wrote: > Put NULL test on the result of the previous call instead on one of its > arguments. A simplified version of the semantic match that finds this > problem is as follows (http://coccinelle.lip6.fr/): > > // > r@ > expression *e1; > expression *e2; > identifier f; > statement S1,S2; > @@ > > e1 = f(...,e2,...); > ( > if (e1 == NULL || ...) S1 else S2 > | > *if (e2 == NULL || ...) S1 else S2 > ) > // > > Signed-off-by: Julia Lawall > > --- Looks right. Linus? > drivers/clk/versatile/clk-versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c > index a76981e..7a4f863 100644 > --- a/drivers/clk/versatile/clk-versatile.c > +++ b/drivers/clk/versatile/clk-versatile.c > @@ -69,7 +69,7 @@ static void __init cm_osc_setup(struct device_node *np, > struct device_node *parent; > > parent = of_get_parent(np); > - if (!np) { > + if (!parent) { > pr_err("no parent on core module clock\n"); > return; > } > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project