From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765888AbcINVet (ORCPT ); Wed, 14 Sep 2016 17:34:49 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:57716 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763219AbcINVep (ORCPT ); Wed, 14 Sep 2016 17:34:45 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: "zhichang.yuan" , devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, gabriele.paoloni@huawei.com, minyard@acm.org, gregkh@linuxfoundation.org, benh@kernel.crashing.org, john.garry@huawei.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, xuwei5@hisilicon.com, linuxarm@huawei.com, linux-serial@vger.kernel.org, linux-pci@vger.kernel.org, zourongrong@gmail.com, liviu.dudau@arm.com, kantyzc@163.com, zhichang.yuan02@gmail.com Subject: Re: [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count Date: Wed, 14 Sep 2016 23:33:56 +0200 Message-ID: <5525856.MfDSSsiP5d@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <57D96701.4050700@hisilicon.com> References: <1473855354-150093-1-git-send-email-yuanzhichang@hisilicon.com> <4340181.AghlmQIy28@wuerfel> <57D96701.4050700@hisilicon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MqVdp/oIb0C+6s1jZ7ZeIZQXi/WzBm8DCjE/fg1GddU9/2t9QfJ BGEGfmiQBp+57/N1sOe7OBAkd+ngOsUQN087qLp+bkBrWw2fHXIpJKmxJ+2VBPFNLEoyKeR MDUc618POuKYCgXAx/lxgPOuqX4FewZjc7E2VhqDtLJSUFpJfjfZoEQSVyhNEoS+piibQ0J 406sMu/fe1F/OEL7UwCyQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FIaAzf+md2c=:v1RX42lyB8cAdBds7g08lS PWKPFt8SITuaBZw8drIUS9lAlAzBPz8VsA48ddnN1uY24EVhSNEChh+6EI2g53ytFz+8Pe/gm +X+0YLNzkDN57TmwKyDDHEH0vC269lAVdtJzK25l08DfiJtn7TEAsTcTu27YHEAZb9LreaGld X03WtDkOWk4Ejt5kt1DQh7DWuGr+MpQYVEwdrBAKKahKIXNtt84a8IG5vZa3XmIveOF3ax08n xOIr5diY95UxVw7eaChgICxqxGH9acpYKiDjMQJyJlci+vgT02OPXLGwKoux9adSRM5oLNXtU WnDJ/hfXyUJO5FIuse7xxnu8+W2HfS8By+V/wdK7lbs1UeafC9Y8da1sAx/CfsgCIj0oid4oo skYtjX515MZU/bmsyuhCAjB/U37GCw9EW3Et+ANPa4E4Z9MWR6aGvlIDbfJ+jCeBfq9PgqVL2 Y2ORBLU9rO23AWuTUnn67/dG24RHdL6DggkvhXl33TxfmPSTcL+3p0Sm+zG++Lzcz01Ozx/uE oTEeUm985dBZXUUcGD9KIDT8CUF7ZmAWMuEnSNmMy21CIS9PebxkZwqKuVmXAlOyPRCltNx2P I2TBA/JPJmPqrOKSJQXLpaERW2oZMvzZJWn8zY1wNxgWBp+aDVhjfZ+K/xXnZDy8CZea9PaL7 C0Flr9t7AlrJ3L/9Luxk4GdffqEwOqVOaxxNZ4mcX6fUBpMlfE3rg0Ho+06FkA9Vhjm9l3vx+ eHX3BcTHF2nod/SB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 14, 2016 11:04:33 PM CEST zhichang.yuan wrote: > The 8250_hisi_lpc.c support both ACPI and dts similar to 8250_dw : > > +static struct platform_driver hs_lpc8250_driver = { > + .driver = { > + .name = "hisi-lpc-uart", > + .of_match_table = hs8250_of_match, > + .acpi_match_table = ACPI_PTR(hs8250_acpi_match), > > So, I am a little confused why we need to support dts in 8250_of.c and support ACPI in another > driver file. > After looking again, I'm pretty sure that drivers/tty/serial/8250/8250_pnp.c will handle the ACPI case without modifications, you just need to adapt the 8250_of driver to handle IORESOURCE_IO ports. This will be required anyway with the next version once the LPC bridge is on the PCI bus. Arnd