From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754907AbbDIDkQ (ORCPT ); Wed, 8 Apr 2015 23:40:16 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60103 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754795AbbDIDkN (ORCPT ); Wed, 8 Apr 2015 23:40:13 -0400 Message-ID: <5525F498.5040203@roeck-us.net> Date: Wed, 08 Apr 2015 20:40:08 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ralf Baechle CC: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Andy Lutomirski , David Daney Subject: Re: [PATCH] mips: Fix build if PERF_EVENTS is configured References: <1428524992-5979-1-git-send-email-linux@roeck-us.net> <20150409000934.GA21107@linux-mips.org> In-Reply-To: <20150409000934.GA21107@linux-mips.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.5525F49D.0018,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 9 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2015 05:09 PM, Ralf Baechle wrote: > On Wed, Apr 08, 2015 at 01:29:52PM -0700, Guenter Roeck wrote: > >> mips builds fail in -next as follows if PERF_EVENTS is configured. >> >> kernel/built-in.o: In function `perf_sample_regs_user': >> kernel/events/core.c:4828: undefined reference to `perf_get_regs_user' >> >> The problem is caused by commit 3478e32c1545 ("MIPS: Add user stack and >> registers to perf.") in combination with commit 88a7c26af8da ("perf: >> Move task_pt_regs sampling into arch code"), which introduces >> perf_get_regs_user(). >> >> Cc: Andy Lutomirski >> Cc: David Daney >> Signed-off-by: Guenter Roeck > > I've already applied the same change locally but due to patch ordering > constraints I'm considering to temporarily pull this patch until the > perf stuff and the remainder of the MIPS changes are in 4.1 or so. > Hi Ralf, Does it hurt to have the function if 88a7c26af8da is not in the tree ? Sure, you'll get a smatch and/or sparse warning, but I would consider that to be less severe than build failures. Thanks, Guenter