From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754998AbbDIDyQ (ORCPT ); Wed, 8 Apr 2015 23:54:16 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:33519 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbbDIDyO (ORCPT ); Wed, 8 Apr 2015 23:54:14 -0400 Message-ID: <5525F7D6.2040304@linaro.org> Date: Thu, 09 Apr 2015 12:53:58 +0900 From: AKASHI Takahiro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mark Rutland CC: Catalin Marinas , Will Deacon , Marc Zyngier , "christoffer.dall@linaro.org" , "geoff@infradead.org" , "broonie@kernel.org" , "david.griego@linaro.org" , "freddy77@gmail.com" , "kexec@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" Subject: Re: [v3 1/5] arm64: kvm: add a cpu tear-down function References: <1427953216-11737-1-git-send-email-takahiro.akashi@linaro.org> <1427953216-11737-2-git-send-email-takahiro.akashi@linaro.org> <20150408130221.GA5977@leverpostej> In-Reply-To: <20150408130221.GA5977@leverpostej> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2015 10:02 PM, Mark Rutland wrote: >> + /* We're now in idmap, disable MMU */ >> +1: mrs x0, sctlr_el2 >> + and x1, x0, #SCTLR_EL2_EE >> + orr x0, x0, x1 // preserve endianness of EL2 >> + ldr x1, =SCTLR_EL2_FLAGS >> + eor x1, x1, xzr >> + bic x0, x0, x1 // Clear SCTL_M and etc >> + msr sctlr_el2, x0 >> + isb > > This can instead be: > > 1: mrs x0, sctlr_el2 > ldr x1, =SCTLR_EL2_FLAGS > bic x0, x0, x1 > msr sctlr_el2, x0 > isb > > As SCTLR_EL2_FLAGS doesn't contain the EE bit. Oops. I will fix it. Thanks, -Takahiro AKASHI > Mark. >