From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbbDILqB (ORCPT ); Thu, 9 Apr 2015 07:46:01 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51611 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170AbbDILp7 (ORCPT ); Thu, 9 Apr 2015 07:45:59 -0400 Message-ID: <5526667C.5020003@kernel.org> Date: Thu, 09 Apr 2015 12:46:04 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Irina Tirdea , linux-iio@vger.kernel.org, Hartmut Knaack CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] iio: accel: mma9553: check input value for activity period References: <1428503857-9081-1-git-send-email-irina.tirdea@intel.com> <1428503857-9081-7-git-send-email-irina.tirdea@intel.com> In-Reply-To: <1428503857-9081-7-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/15 15:37, Irina Tirdea wrote: > When setting the activity period, the value introduced by > the user in sysfs is not checked for validity. > > Add a boundary check so that only allowed values are > reported as suuccesfully written to device. > > Signed-off-by: Irina Tirdea > Suggested-by: Hartmut Knaack Good point. This one counts as a fix so put it early in the reordered series. > --- > drivers/iio/accel/mma9553.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c > index 57868fb..96e4708 100644 > --- a/drivers/iio/accel/mma9553.c > +++ b/drivers/iio/accel/mma9553.c > @@ -839,6 +839,9 @@ static int mma9553_write_event_value(struct iio_dev *indio_dev, > case IIO_EV_INFO_PERIOD: > switch (chan->type) { > case IIO_ACTIVITY: > + if (val < 0 || val > MMA9553_ACTIVITY_THD_TO_SEC( > + MMA9553_MAX_ACTTHD)) > + return -EINVAL; > mutex_lock(&data->mutex); > ret = mma9553_set_config(data, MMA9553_REG_CONF_ACTTHD, > &data->conf.actthd, >