From: Jonathan Cameron <jic23@kernel.org>
To: Vlad Dogaru <vlad.dogaru@intel.com>,
Irina Tirdea <irina.tirdea@intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH] iio: pressure: bmp280: fix temp compensation
Date: Thu, 09 Apr 2015 12:56:26 +0100 [thread overview]
Message-ID: <552668EA.3060409@kernel.org> (raw)
In-Reply-To: <20150408153034.GA23781@vdogaru>
On 08/04/15 16:30, Vlad Dogaru wrote:
> On Wed, Apr 08, 2015 at 06:26:12PM +0300, Irina Tirdea wrote:
>> Temperature reads on bmp280 device always return 0,
>> due to a missing step in the compensation formula
>> (data->tfine is never initialized).
>>
>> Initialize data->tfine value so we get correct
>> temperature and pressure values.
>>
>> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
>
> Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>
>
> Nice catch, this must have been lost during a refactoring.
>
> Thanks,
> Vlad
>
Thanks,
Applied to fixes-togreg which is now based on staging-next
which gives you an idea of when this will go to Greg now!
prev parent reply other threads:[~2015-04-09 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 15:26 [PATCH] iio: pressure: bmp280: fix temp compensation Irina Tirdea
2015-04-08 15:30 ` Vlad Dogaru
2015-04-09 11:56 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552668EA.3060409@kernel.org \
--to=jic23@kernel.org \
--cc=irina.tirdea@intel.com \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox