From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324AbbDIW2X (ORCPT ); Thu, 9 Apr 2015 18:28:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:60911 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbbDIW2V (ORCPT ); Thu, 9 Apr 2015 18:28:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,552,1422950400"; d="scan'208";a="553822157" Message-ID: <5526FCFF.5090800@linux.intel.com> Date: Thu, 09 Apr 2015 15:28:15 -0700 From: sathyanarayanan kuppuswamy Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Organization: Intel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Daniel Baluta , Jonathan Cameron CC: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, "Kuppuswamy, Sathyanarayanan" Subject: Re: [RFC PATCH 2/2] iio: light: Add support for LTR559 chip References: <1427798235-29602-1-git-send-email-daniel.baluta@intel.com> <1427798235-29602-3-git-send-email-daniel.baluta@intel.com> <552680FF.3060604@kernel.org> <5526823A.6070404@intel.com> In-Reply-To: <5526823A.6070404@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2015 06:44 AM, Daniel Baluta wrote: > > > On 04/09/2015 04:39 PM, Jonathan Cameron wrote: >> On 31/03/15 11:37, Daniel Baluta wrote: >>> This device is register compatible with LTR501, with a minor >>> difference for >>> ALS control register as showed below: >>> >>> ALS Control register for LTR501: >>> >>> 7 6 5 4 3 2 1 0 >>> +------+------+------+------+------+------+------+------+ >>> | | | | | >>> | Reserved | Gain | SW | ALS Mode | >>> | | | Reset| | >>> +------+------+------+------+------+------+------+------+ >>> >>> ALS Control register for LTR559: >>> >>> 7 6 5 4 3 2 1 0 >>> +------+------+------+------+------+------+------+------+ >>> | | | | | >>> | Reserved | Gain | SW | ALS | >>> | | | Reset| Mode | >>> +------+------+------+------+------+------+------+------+ >>> >>> We handle this difference by introducing ltr501_chip_info. >>> >>> Datasheet for LTR559 is at: >>> http://optoelectronics.liteon.com/upload/download/DS86-2013-0003/S_110_LTR-559ALS-01_DS_V1.pdf >>> >>> >>> Signed-off-by: Daniel Baluta >> Looks good to me. Let us know when you've tested it ;) >> Anyhow, one comment inline. It 'think' you can end up with a device >> probing >> succesfully with no known name... > > Good point. > > thanks, > Daniel. > > > >>> - indio_dev->name = LTR501_DRV_NAME; >>> + indio_dev->name = name; >> Can name still be NULL? Needs a default value that makes sense. >>> indio_dev->modes = INDIO_DIRECT_MODE; > > I will fix this and sync with Sathya for the LTR301 support. I will send you the re-based LTR301 patch. Please add it your patch set. > > thanks, > Daniel. > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sathyanarayanan Kuppuswamy Android kernel developer