From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754575AbbDJGnH (ORCPT ); Fri, 10 Apr 2015 02:43:07 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:10758 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460AbbDJGnD (ORCPT ); Fri, 10 Apr 2015 02:43:03 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee690-f796f6d000005054-bf-552770e4fdd7 Content-transfer-encoding: 8BIT Message-id: <552770E4.3070508@samsung.com> Date: Fri, 10 Apr 2015 15:42:44 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, j.anaszewski@samsung.com, varkabhadram@gmail.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v5 3/3] leds: Add ktd2692 flash LED driver References: <1427860708-32559-1-git-send-email-ingi2.kim@samsung.com> <1427860708-32559-4-git-send-email-ingi2.kim@samsung.com> <1427861250.18175.51.camel@perches.com> In-reply-to: <1427861250.18175.51.camel@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWyRsSkSPdJgXqowcc5FhZHd05ksrj+5Tmr xfwj51gt+t8sZLXY9fc+o8W5VysZLXqvPme0uPGrjdVi9v3HLBaXd81hs9j6Zh2jxdLrF5ks Jkxfy2LRuvcIu8XuXU9ZLc7sX8lmMWPySzaLkx1zGB2EPNbMW8Pocbmvl8lj56y77B4rl39h 8zj8dSGLx6ZVnWweX1ZdY/bYM/8Hq0ffllWMHp83yQVwRXHZpKTmZJalFunbJXBlnLt5hbHg EH/Fv42fWBsYb/J0MXJySAiYSGxavYkZwhaTuHBvPVsXIxeHkMBSRokn52aywBR9PfaJBSIx nVHiW88ZVpAEr4CgxI/J94ASHBzMAvISRy5lQ5jqElOm5EKUP2CUuPqvlx2iXEvixKSJTCA2 i4CqxMp5H8DmswmoSdxYsZAJpFdUIEKi+0QliCkioChxdws/yBhmgUXMEk82f2EHiQsL2En8 7DSCGL+aUeL+6p9gYziBzuy9cRvsfgmBAxwSV35NZoXYJSDxbfIhsDMlBGQlNh2A+ldS4uCK GywTGMVmIXlmFsIzsxCeWcDIvIpRNLUguaA4Kb3IRK84Mbe4NC9dLzk/dxMjMB2c/vdswg7G ewesDzEKcDAq8fA2xKqHCrEmlhVX5h5iNAW6YSKzlGhyPjDp5JXEGxqbGVmYmpgaG5lbmimJ 876W+hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgXFFkcJCdlNPV/l2q3P3qp5z99im7ZzK +i/eop99yQHTjC9pxfXyTwu1bwhtrL0X7DtFyfxH/cuys09LZCZFle369lEw+7SNX/KK66+4 7tcyOC2quGanHtbjXnlihV2R97ySMzoVjvrCBbInLmrPPW7QJpovUtrdy/D0GQvPeUnxV3vL T3y7oMRSnJFoqMVcVJwIABm2HJ0CAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJKsWRmVeSWpSXmKPExsVy+t9jQd0nBeqhBv0N+hZHd05ksrj+5Tmr xfwj51gt+t8sZLXY9fc+o8W5VysZLXqvPme0uPGrjdVi9v3HLBaXd81hs9j6Zh2jxdLrF5ks Jkxfy2LRuvcIu8XuXU9ZLc7sX8lmMWPySzaLkx1zGB2EPNbMW8Pocbmvl8lj56y77B4rl39h 8zj8dSGLx6ZVnWweX1ZdY/bYM/8Hq0ffllWMHp83yQVwRTUw2mSkJqakFimk5iXnp2Tmpdsq eQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA/aWkUJaYUwoUCkgsLlbSt8M0ITTETdcC pjFC1zckCK7HyAANJKxhzDh38wpjwSH+in8bP7E2MN7k6WLk5JAQMJH4euwTC4QtJnHh3nq2 LkYuDiGB6YwS33rOsIIkeAUEJX5MvgdUxMHBLCAvceRSNoSpLjFlSi5E+QNGiav/etkhyrUk TkyayARiswioSqyc9wFsPpuAmsSNFQuZQHpFBSIkuk9UgpgiAooSd7fwg4xhFljELPFk8xd2 kLiwgJ3Ez04jiPGrGSXur/4JNoYT6OTeG7fZJjAKzEJy3CyE42YhHLeAkXkVo2hqQXJBcVJ6 rpFecWJucWleul5yfu4mRnCyeSa9g3FVg8UhRgEORiUe3oZY9VAh1sSy4srcQ4wSHMxKIryV ICHelMTKqtSi/Pii0pzU4kOMpkCvTWSWEk3OBybCvJJ4Q2MTMyNLI3NDCyNjcyVx3jm6cqFC AumJJanZqakFqUUwfUwcnFINjM7rv4oGuThk9j8QTuKZdXPrwbc7j/VZNecYxSW/+vTg70xd wePvXhib9X54OCvmr6hH9d2dPs5SKaaKmzj3BM834tWTOvFWT/hPq6H3h69zT0itzzCy+n7j 2r7MDdWbT1r+Yj+wUuRt60JHPXamvN4zZatM3jCcWGDAHSGttjU+QfdFsW1nkBJLcUaioRZz UXEiAL+3ArZMAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, Thanks for the review. On 2015년 04월 01일 13:07, Joe Perches wrote: > On Wed, 2015-04-01 at 12:58 +0900, Ingi Kim wrote: >> This patch adds a driver to support the ktd2692 flash LEDs. >> ktd2692 can control flash current by ExpressWire interface. > > trivia: > >> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c > [] >> +static void ktd2692_brightness_set(struct ktd2692_context *led, >> + enum led_brightness brightness) >> +{ >> + mutex_lock(&led->lock); >> + >> + if (brightness == LED_OFF) { >> + led->mode = KTD2692_MODE_DISABLE; >> + gpio_set_value(led->aux_gpio, KTD2692_LOW); >> + goto out; >> + } >> + >> + ktd2692_expresswire_write(led, KTD2692_REG_MOVIE_CURRENT_BASE | >> + KTD2692_BRIGHTNESS_RANGE_255_TO_8(brightness)); >> + led->mode = KTD2692_MODE_MOVIE; >> + >> +out: >> + ktd2692_expresswire_write(led, led->mode | KTD2692_REG_MODE_BASE); >> + mutex_unlock(&led->lock); >> +} > > Perhaps this function would be better with if/else > without the out: label > >> +static int ktd2692_led_flash_strobe_set(struct led_classdev_flash *fled_cdev, >> + bool state) >> +{ >> + struct ktd2692_context *led = fled_cdev_to_led(fled_cdev); >> + struct led_flash_setting *timeout = &fled_cdev->timeout; >> + u32 flash_tm_reg; >> + >> + mutex_lock(&led->lock); >> + >> + if (state == 0) { >> + led->mode = KTD2692_MODE_DISABLE; >> + gpio_set_value(led->aux_gpio, KTD2692_LOW); >> + goto done; >> + } >> + >> + flash_tm_reg = GET_TIMEOUT_OFFSET(timeout->val, timeout->step); >> + ktd2692_expresswire_write(led, flash_tm_reg >> + | KTD2692_REG_FLASH_TIMEOUT_BASE); >> + >> + led->mode = KTD2692_MODE_FLASH; >> + gpio_set_value(led->aux_gpio, KTD2692_HIGH); >> + >> +done: >> + ktd2692_expresswire_write(led, led->mode | KTD2692_REG_MODE_BASE); > > Same if/else with the done: label? > > Sorry about late comments, It'll be pushed next patch Thank you