From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965514AbbDJNiG (ORCPT ); Fri, 10 Apr 2015 09:38:06 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:12420 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965389AbbDJNh7 (ORCPT ); Fri, 10 Apr 2015 09:37:59 -0400 X-AuditID: cbfec7f4-b7f106d0000013ec-a0-5527d1874a29 Message-id: <5527D22E.9090000@samsung.com> Date: Fri, 10 Apr 2015 16:37:50 +0300 From: Andrey Ryabinin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 2/2] arm64: add KASan support References: <1427208544-8232-1-git-send-email-a.ryabinin@samsung.com> <3164609.kEhR8riVSV@wuerfel> <5527AA94.5080803@samsung.com> <8790947.ikOtIjWHkt@wuerfel> In-reply-to: <8790947.ikOtIjWHkt@wuerfel> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t/xy7rtF9VDDaattLKYs34Nm8XfScfY Ld4v62G02PT4GqvF5V1z2CzurfnPavHy4wkWB3aPNfPWMHr8/jWJ0WPTp0nsHidm/Gbx2Lyk 3uPzJrkAtigum5TUnMyy1CJ9uwSujJ9/NjEW3GKvuP3qCEsD4yS2LkYODgkBE4kZL+26GDmB TDGJC/fWA4W5OIQEljJK9G3ZxgLhNDNJLPyyiAmkildAS2Ll4vPsIDaLgKrE3RlHGEFsNgE9 iX+ztoMNFRWIkLh9mROiXFDix+R7LCC2iICixNQXz5hBbGaBm4wSHVsyQWxhAUOJxZf3Qu1a xCix7cx3NpAEp4CmxLWbn9hBZjIDzb9/UQuiV15i85q3zBMYBWYhWTELoWoWkqoFjMyrGEVT S5MLipPScw31ihNzi0vz0vWS83M3MUIC/csOxsXHrA4xCnAwKvHwXlisHirEmlhWXJl7iFGC g1lJhLdqLVCINyWxsiq1KD++qDQntfgQIxMHp1QD4/oj5+7GnSkKNzSW4bfe3vxIafXy1CcP klyNL/s+LVGOeVo0q/5gwq39dv9iBJdKWT4++u+09DSvWY/uTP7e0/p176zvUb4Jhc8OLJR4 onPTyv5+yqLt2xviihK4omZlHgzbyehkbd0jUCoyMy1Ef79gQk9ASfI6V9ZP1uk3dawCLhdU lrgGKLEUZyQaajEXFScCAE+zzj9SAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2015 04:02 PM, Arnd Bergmann wrote: > On Friday 10 April 2015 13:48:52 Andrey Ryabinin wrote: >> On 04/09/2015 11:17 PM, Arnd Bergmann wrote: >>> On Tuesday 24 March 2015 17:49:04 Andrey Ryabinin wrote: >>>> arch/arm64/mm/kasan_init.c | 211 +++++++++++++++++++++++++++++++++++ >>>> >>> >>> Just one very high-level question: as this code is clearly derived from >>> the x86 version and nontrivial, could we move most of it out of >>> arch/{x86,arm64} into mm/kasan/init.c and have the rest in some header >>> file? >>> >> >> I think most of this could be moved out from arch code, but not everything. >> E.g. kasan_init() function is too arch-specific. > > Right, makes sense. So presumably, populate_zero_shadow could become a global > function by another name, and possibly also handle registering the die > handler, so you can call it from an architecture specific kasan_init() > function, right? > Yep, you are right. > Arnd >