From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
RTCLINUX <rtc-linux@googlegroups.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH 1/2] char: PC rtc: replace blacklist with whitelist
Date: Mon, 18 Apr 2016 13:41:20 +0200 [thread overview]
Message-ID: <5528499.2P7TrvXfau@wuerfel> (raw)
In-Reply-To: <CAMuHMdWQiqNq7-fgn5NONovLQxhOoGD5s-TAYVYZOVRfEs52Zg@mail.gmail.com>
On Monday 18 April 2016 09:09:55 Geert Uytterhoeven wrote:
> Hi Arnd,
>
> cc linux-m68k
>
> On Sun, Apr 17, 2016 at 11:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 02 March 2016 11:22:04 Geert Uytterhoeven wrote:
> >> On Wed, Mar 2, 2016 at 10:48 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > Every new architecture has to add itself to the growing list of those
> >> > that do not support the legacy PC RTC driver.
> >> >
> >> > This replaces the long list of architectures that don't support it
> >> > with a shorter list of those that do.
> >> >
> >> > The list is taken from those architectures that have a non-empty
> >> > asm/mc146818rtc.h header file and were not explicitly blacklisted.
> >>
> >> M68K was blacklisted...
> >
> > I never got back to you on this topic, sorry about that. I've fixed
> > up the patch to leave out m68k now.
> >
> > On a semi-related note, I see that m68k is one of the few architectures
> > still using the (other) genrtc driver. It would be nice to reduce that
> > list and change m68k to use its own rtc driver (ideally one per
>
> We do have hp_sdc_rtc (HP9000/300; why is that under drivers/input/misc/?),
> and rtc-msm6242 and rtc-rp5c01 (both for Amiga).
fwiw, the hp_sdc_rtc driver does not actually implement the RTC ioctls
(they are there, but commented out).
The other ones are good, you just have two incompatible ways of doing
it because the drivers/rtc subsystem is can not be built into the
kernel at the same time as the old gen_rtc driver for the q40.
> > platform), but the q40 platform is the only one providing
> > get_rtc_pll()/set_rtc_pll() for the RTC_PLL_GET/RTC_PLL_SET ioctl
> > commands.
>
> Do you mean this is a problem?
Not a big one, assuming that either nobody actually needs these ioctls
(very likely), or they don't care about having a single kernel for
q40 and the other platforms.
The main issue I see is migrating architectures over from gen_rtc to
rtc-generic over time, but this effort has been going on for at least
a decade and there is no rush, but it would still be nice.
Arnd
prev parent reply other threads:[~2016-04-18 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 9:48 [PATCH 1/2] char: PC rtc: replace blacklist with whitelist Arnd Bergmann
2016-03-02 9:48 ` [PATCH 2/2] char: genrtc: " Arnd Bergmann
2016-03-02 10:03 ` Alexandre Belloni
2016-03-02 10:25 ` Geert Uytterhoeven
2016-03-02 10:03 ` [PATCH 1/2] char: PC rtc: " Alexandre Belloni
2016-03-02 10:22 ` Geert Uytterhoeven
2016-04-10 15:43 ` Alexandre Belloni
2016-04-17 16:16 ` Arnd Bergmann
2016-04-17 21:37 ` Arnd Bergmann
2016-04-18 7:09 ` Geert Uytterhoeven
2016-04-18 11:41 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5528499.2P7TrvXfau@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox