From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbcDRLmD (ORCPT ); Mon, 18 Apr 2016 07:42:03 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:63660 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbcDRLl7 (ORCPT ); Mon, 18 Apr 2016 07:41:59 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Geert Uytterhoeven , RTCLINUX , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , linux-m68k , Alexandre Belloni Subject: Re: [PATCH 1/2] char: PC rtc: replace blacklist with whitelist Date: Mon, 18 Apr 2016 13:41:20 +0200 Message-ID: <5528499.2P7TrvXfau@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1456912137-1578635-1-git-send-email-arnd@arndb.de> <4192558.Mh1hb3LCLb@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TThgAt5JaMaezvErXEjtGaXIYlr5W+bFfj9HwSgrcGaTSwiVT0f UY2JGXr3s9q2iZA3Nd+5Hd4/Ta45ULYcVN2kCW+8wZg1bchIjoh6MPgML5Gsgu7dmgDOTKV TG7MJCvKzViOfYcdrxbnWCeSGc5gsU8d2afgYIdhYAI4Xh//jckW0CiPaRLrnrsq1+dh5lY pMwR6LucxhYWZ9CPsj6jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:MW2tGiY+5ss=:buPh9jbfUjcJ49u9kIzlVB PNzMESSOnWgwfZ1BcewWG0vp/ZFxXvGqsA/Ulmf85ZNwUdSzWJVUiTtZn+eY9TstdBXOnG+5l PyioYNHYLw0vMMlv84HbZZBvPYK2+T6SnRluEEwEI2uWO/xuOptYEmGUN+uUGVGpcA4Szlmgz WZFy96UKPFsSX+Nr6ZCC2Xxl2aJ4sat/FrjqB8smsc6JV2gLPknDdG97JVqkwqohTbx09mXYK eJtQ/QAjdweUjqwcFkkQeXKxMCBnPBcglwUCgsqSOSfqKR3PYxIb4nDgwRJapa/u2xX4CYbln 4zuRqBd7WVS7Sx6KAFcfZ76+p6wPFEd++VxN/rUrlh7wRN9m7yzo7Z9V1sp3U4qbeExv9BMZi sjC12gBmamVl4pwi9l4N+65J8morgmhs+pF9vinlPozAE17CMs4O6uUd5v7mDDWgiowA9EQTq YOL7OYxWTqQIc/9uRp3x/BKPn9X1RLZHEwpmONi8vNdtYOW0JTOWC+3VdUP/nM4hscEZkK4WD fvy+vdL8j/BSIg4moNIxLGS0atCTyB78qDaqvTOKlTnM5jvYEdlJK+KZEvK8ZZthQQU2Pyhtx e6AreKfuwTMFU1HSyHBacfZvGlUIQ+P+UJGzDefrnbDh1d8MyOIVtBsJIIfaiOQQGVTmW7RYI pZmZ9SmQoM6UDpNU4hZ6XJWw+xrjmjyTHeID7wrJRWBvQcoQm3M69StkAqtyiHDCxRRrKSKM5 lSmwF2jGrplSZ+MY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 April 2016 09:09:55 Geert Uytterhoeven wrote: > Hi Arnd, > > cc linux-m68k > > On Sun, Apr 17, 2016 at 11:37 PM, Arnd Bergmann wrote: > > On Wednesday 02 March 2016 11:22:04 Geert Uytterhoeven wrote: > >> On Wed, Mar 2, 2016 at 10:48 AM, Arnd Bergmann wrote: > >> > Every new architecture has to add itself to the growing list of those > >> > that do not support the legacy PC RTC driver. > >> > > >> > This replaces the long list of architectures that don't support it > >> > with a shorter list of those that do. > >> > > >> > The list is taken from those architectures that have a non-empty > >> > asm/mc146818rtc.h header file and were not explicitly blacklisted. > >> > >> M68K was blacklisted... > > > > I never got back to you on this topic, sorry about that. I've fixed > > up the patch to leave out m68k now. > > > > On a semi-related note, I see that m68k is one of the few architectures > > still using the (other) genrtc driver. It would be nice to reduce that > > list and change m68k to use its own rtc driver (ideally one per > > We do have hp_sdc_rtc (HP9000/300; why is that under drivers/input/misc/?), > and rtc-msm6242 and rtc-rp5c01 (both for Amiga). fwiw, the hp_sdc_rtc driver does not actually implement the RTC ioctls (they are there, but commented out). The other ones are good, you just have two incompatible ways of doing it because the drivers/rtc subsystem is can not be built into the kernel at the same time as the old gen_rtc driver for the q40. > > platform), but the q40 platform is the only one providing > > get_rtc_pll()/set_rtc_pll() for the RTC_PLL_GET/RTC_PLL_SET ioctl > > commands. > > Do you mean this is a problem? Not a big one, assuming that either nobody actually needs these ioctls (very likely), or they don't care about having a single kernel for q40 and the other platforms. The main issue I see is migrating architectures over from gen_rtc to rtc-generic over time, but this effort has been going on for at least a decade and there is no rush, but it would still be nice. Arnd