From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753557AbbDKGcn (ORCPT <rfc822;w@1wt.eu>);
	Sat, 11 Apr 2015 02:32:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33257 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751519AbbDKGcm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 11 Apr 2015 02:32:42 -0400
Message-ID: <5528BFEA.5080103@redhat.com>
Date: Sat, 11 Apr 2015 08:32:10 +0200
From: Hans de Goede <hdegoede@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: kbuild test robot <fengguang.wu@intel.com>,
        Masaki Ota <masaki.ota@jp.alps.com>
CC: kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        =?windows-1252?Q?Pali_Roh=E1r?= <pali.rohar@gmail.com>,
        Yunkang Tang <yunkang.tang@cn.alps.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] Input: alps_get_pkt_id_ss4_v2() can be static
References: <201504110955.4uEmNJDX%fengguang.wu@intel.com> <20150411012111.GA64853@snb>
In-Reply-To: <20150411012111.GA64853@snb>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 04/11/2015 03:21 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Ack, these should all be static:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Dmitry, can you please merge this one ?

Regards,

Hans

> ---
>   alps.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index ad741c0..3ef93ff 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse)
>   		alps_process_touchpad_packet_v7(psmouse);
>   }
>
> -unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
> +static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
>   {
>   	unsigned char pkt_id = SS4_PACKET_ID_IDLE;
>
> @@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse,
>   	return 0;
>   }
>
> -int alps_update_device_area_ss4_v2(unsigned char otp[][4],
> +static int alps_update_device_area_ss4_v2(unsigned char otp[][4],
>   				   struct alps_data *priv)
>   {
>   	int num_x_electrode;
> @@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4],
>   	return 0;
>   }
>
> -int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
> +static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
>   {
>
>   	unsigned char is_btnless;
>