From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754230AbbDNI1Z (ORCPT ); Tue, 14 Apr 2015 04:27:25 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:55934 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbbDNI1S (ORCPT ); Tue, 14 Apr 2015 04:27:18 -0400 Message-ID: <552CCF5E.5040201@linux.vnet.ibm.com> Date: Tue, 14 Apr 2015 13:57:10 +0530 From: Preeti U Murthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "Shreyas B. Prabhu" , linux-kernel@vger.kernel.org, Michael Ellerman , "benh@kernel.crashing.org" CC: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 3/3] powerpc/powernv: Introduce sysfs control for fastsleep workaround behavior References: <1428976613-13007-1-git-send-email-shreyas@linux.vnet.ibm.com> <1428976613-13007-4-git-send-email-shreyas@linux.vnet.ibm.com> In-Reply-To: <1428976613-13007-4-git-send-email-shreyas@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15041408-0025-0000-0000-000009DD1C9E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shreyas, On 04/14/2015 07:26 AM, Shreyas B. Prabhu wrote: > + * fastsleep_workaround_state = WORKAROUND_APPLYONCE implies > + * fastsleep workaround needs to be left in 'applied' state on all > + * the cores. Do this by- > + * 1. Patching out the call to 'undo' workaround in fastsleep exit path > + * 2. Sending ipi to all the cores which have atleast one online thread > + * 3. Patching out the call to 'apply' workaround in fastsleep entry > + * path > + * There is no need to send ipi to cores which have all threads > + * offlined, as last thread of the core entering fastsleep or deeper > + * state would have applied workaround. > + */ > + err = patch_instruction( > + (unsigned int *)pnv_fastsleep_workaround_at_exit, > + PPC_INST_NOP); > + if (err) { > + pr_err("fastsleep_workaround_state change failed while patching pnv_fastsleep_workaround_at_exit"); > + goto fail; > + } > + > + primary_thread_mask = cpu_online_cores_map(); > + on_each_cpu_mask(&primary_thread_mask, > + pnv_fastsleep_workaround_apply, > + &err, 1); > + if (err) { > + pr_err("fastsleep_workaround_state change failed while running pnv_fastsleep_workaround_apply"); > + goto fail; > + } > + > + err = patch_instruction( > + (unsigned int *)pnv_fastsleep_workaround_at_entry, > + PPC_INST_NOP); > + if (err) { > + pr_err("fastsleep_workaround_state change failed while patching pnv_fastsleep_workaround_at_entry"); > + goto fail; > + } A point that bothers me here is if we can potentially race with cpu hotplug ? If cpuX and its siblings are offline and it was interrupted to come online: cpuX cpuY Interrupted to come online Undo workaround Nop the fastsleep_workaround_exit path IPI online cores: apply workaround once Set yourself in the online mask Nop the fastsleep_workaround_entry path This results in cpuX undoing the workaround on its core, never to set it back again. So should we protect the region between the beginning and end of patching instructions with get_online_cpus() and put_online_cpus() ? Regards Preeti U Murthy