[PATCH] spi: bcm2835: Add GPIOLIB dependency

[PATCH] spi: bcm2835: Add GPIOLIB dependency

[Guenter Roeck]

Fix:

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
			dereferencing pointer to incomplete type
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:2: error:
	`		implicit declaration of function 'gpiochip_find'
drivers/spi/spi-bcm2835.c:387:21: error:
			dereferencing pointer to incomplete type

by adding the now mandatory GPIOLIB dependency.

Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
	on first spi_setup")
Cc: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b7fb45..a132180a9251 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -78,6 +78,7 @@ config SPI_ATMEL
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
 	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on GPIOLIB
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.
 
-- 
2.1.0

Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency

[Martin Sperl]

> On 14.04.2015, at 06:24, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> by adding the now mandatory GPIOLIB dependency.
> 
Note this shows up during automated randconfig testing.

> Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
> 	on first spi_setup")
> Cc: Martin Sperl <kernel@martin.sperl.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I have had an identical patch in the pipeline as well, but
I was still testing it over the night.

Signed-off-by: Martin Sperl <kernel@martin.sperl.org>

Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency

[Guenter Roeck]

On 04/13/2015 10:48 PM, Martin Sperl wrote:
>
>> On 14.04.2015, at 06:24, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> by adding the now mandatory GPIOLIB dependency.
>>
> Note this shows up during automated randconfig testing.
>

Also for m68k:allmodconfig and mips:allmodconfig in both mainline and -next.

http://server.roeck-us.net:8010/builders/hwmon-m68k-master/builds/129
http://server.roeck-us.net:8010/builders/hwmon-mips-master/builds/129

Guenter

Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Mon, Apr 13, 2015 at 09:24:48PM -0700, Guenter Roeck wrote:
> Fix:
> 
> drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
> drivers/spi/spi-bcm2835.c:356:21: error:
> 			dereferencing pointer to incomplete type

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]