public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jörg-Volker Peetz" <jvpeetz@web.de>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, Suravee.Suthikulpanit@amd.com,
	joro@8bytes.org
Subject: Re: [PATCH] x86, aperture: Check for GART before accessing GART registers
Date: Tue, 14 Apr 2015 13:15:43 +0200	[thread overview]
Message-ID: <552CF6DF.3000002@web.de> (raw)
In-Reply-To: <20150402171705.GF4579@pd.tnic>

Hi,

tried this patch on my HP Pavilion notebook wiht AMD Phenom II processor. The
BIOS has no IOMMU option.
With this patch I'm still seeing the AGP messages mention in the patch description.
Is this processor affected at all? /proc/cpuinfo says "cpu family" 16. That is 10h?

Regards,
jvp.


Borislav Petkov wrote on 04/02/2015 19:17:
> On Thu, Apr 02, 2015 at 12:04:21PM -0500, Aravind Gopalakrishnan wrote:
>>> No need - I can amend the local copy I have here.
> 
> Here's what I did:
> 
> ---
> From: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> Date: Wed, 1 Apr 2015 09:32:08 -0500
> Subject: [PATCH] x86/gart: Check for GART support before accessing GART
>  registers
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> GART registers are not present in newer AMD processors (Fam15h,
> Model 10h and later). So, avoid accesses to GART registers in PCI
> config space by returning early in early_gart_iommu_check() and
> gart_iommu_hole_init() if GART is not available.
> 
> Current code doesn't break on existing processors but there are some
> side effects:
> 
> We get bogus AGP aperture messages which are simply noise on
> GART-less processors:
> 
>   AGP: Node 0: aperture [bus addr 0x00000000-0x01ffffff] (32MB)
>   AGP: Your BIOS doesn't leave a aperture memory hole
>   AGP: Please enable the IOMMU option in the BIOS setup
>   AGP: This costs you 64MB of RAM
>   AGP: Mapping aperture over RAM [mem 0xd4000000-0xd7ffffff]
> 
<snip>




  parent reply	other threads:[~2015-04-14 11:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 14:32 [PATCH] x86, aperture: Check for GART before accessing GART registers Aravind Gopalakrishnan
2015-04-02  6:59 ` Borislav Petkov
2015-04-02 10:01 ` Ingo Molnar
2015-04-02 15:54   ` Aravind Gopalakrishnan
2015-04-02 16:06     ` Ingo Molnar
2015-04-02 16:23       ` Aravind Gopalakrishnan
2015-04-02 16:53         ` Borislav Petkov
2015-04-02 17:04           ` Aravind Gopalakrishnan
2015-04-02 17:17             ` Borislav Petkov
2015-04-02 18:19               ` Ingo Molnar
2015-04-06 23:10                 ` Aravind Gopalakrishnan
2015-04-07 12:34                   ` Borislav Petkov
2015-04-07 14:46                     ` Aravind Gopalakrishnan
2015-04-07 14:57                       ` Borislav Petkov
2015-04-07 20:34                         ` Aravind Gopalakrishnan
2015-04-08  7:25                           ` Borislav Petkov
2015-04-14 11:15               ` Jörg-Volker Peetz [this message]
2015-04-14 11:33                 ` Borislav Petkov
2015-04-14 18:22                   ` Jörg-Volker Peetz
2015-04-14 18:36                     ` Borislav Petkov
2015-05-04 11:11                       ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552CF6DF.3000002@web.de \
    --to=jvpeetz@web.de \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=bhelgaas@google.com \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox