From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Roger Quadros <rogerq@ti.com>, tglx@linutronix.de
Cc: cw00.choi@samsung.com, balbi@ti.com, tony@atomide.com,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip
Date: Wed, 15 Apr 2015 11:29:44 +0200 [thread overview]
Message-ID: <552E2F88.4000400@free-electrons.com> (raw)
In-Reply-To: <552E1DD3.4040106@ti.com>
On 15/04/2015 10:14, Roger Quadros wrote:
> Without this system suspend is broken on systems that have
> drivers calling enable/disable_irq_wake() for interrupts based off
> the dummy irq hook.
> (e.g. drivers/gpio/gpio-pcf857x.c)
>
> http://article.gmane.org/gmane.linux.kernel/1879035
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
FWIW:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> kernel/irq/dummychip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
> index 988dc58..2feb6fe 100644
> --- a/kernel/irq/dummychip.c
> +++ b/kernel/irq/dummychip.c
> @@ -57,5 +57,6 @@ struct irq_chip dummy_irq_chip = {
> .irq_ack = noop,
> .irq_mask = noop,
> .irq_unmask = noop,
> + .flags = IRQCHIP_SKIP_SET_WAKE,
> };
> EXPORT_SYMBOL_GPL(dummy_irq_chip);
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-04-15 9:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 13:15 [PATCH] genirq: provide dummy set_irq_wake() Roger Quadros
2015-03-30 18:06 ` Felipe Balbi
2015-03-30 18:06 ` Felipe Balbi
2015-04-14 10:13 ` Roger Quadros
2015-04-14 14:02 ` Gregory CLEMENT
2015-04-15 8:07 ` Roger Quadros
2015-04-15 8:51 ` Gregory CLEMENT
2015-04-15 8:14 ` [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip Roger Quadros
2015-04-15 9:29 ` Gregory CLEMENT [this message]
2015-04-24 19:00 ` [tip:irq/urgent] " tip-bot for Roger Quadros
2015-05-11 10:50 ` [PATCH v2] " Geert Uytterhoeven
2015-05-11 11:14 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E2F88.4000400@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=balbi@ti.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox