From: Michal Marek <mmarek@suse.cz>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@systeme.lip6.fr
Subject: Re: [PATCH V2 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning
Date: Wed, 15 Apr 2015 14:22:27 +0200 [thread overview]
Message-ID: <552E5803.6050902@suse.cz> (raw)
In-Reply-To: <1428613084-2861-1-git-send-email-fabf@skynet.be>
On 2015-04-09 22:58, Fabian Frederick wrote:
> if()/BUG conversion to BUG_ON must be avoided when there's side effect
> in condition. The reason being BUG_ON won't execute the condition when CONFIG_BUG
> is not defined.
>
> Inspired-by: J. Bruce Fields <bfields@fieldses.org>
> Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Acked-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: s/condition/the condition/
Applied to kbuild.git#misc.
Michal
prev parent reply other threads:[~2015-04-15 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 20:58 [PATCH V2 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning Fabian Frederick
2015-04-15 12:22 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E5803.6050902@suse.cz \
--to=mmarek@suse.cz \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=cocci@systeme.lip6.fr \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox