From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: weiyj_lk@163.com, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>, Jin Yao <yao.jin@linux.intel.com>,
Jie Yang <yang.jie@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: sst_byt: remove kfree for memory allocated with devm_kzalloc
Date: Thu, 16 Apr 2015 17:05:33 +0300 [thread overview]
Message-ID: <552FC1AD.7030207@linux.intel.com> (raw)
In-Reply-To: <1429191989-25919-1-git-send-email-weiyj_lk@163.com>
Hi
On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/intel/baytrail/sst-baytrail-ipc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c b/sound/soc/intel/baytrail/sst-baytrail-ipc.c
> index 1efb33b..a839dbf 100644
> --- a/sound/soc/intel/baytrail/sst-baytrail-ipc.c
> +++ b/sound/soc/intel/baytrail/sst-baytrail-ipc.c
> @@ -759,7 +759,6 @@ fw_err:
> dsp_new_err:
> sst_ipc_fini(ipc);
> ipc_init_err:
> - kfree(byt);
>
> return err;
> }
>
Above kfree(byt) appears to be added by accident in the commit
48cec59b6f38 ("ASoC: Intel: Use the generic IPC/mailbox APIs in Baytrail").
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2015-04-16 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 13:46 [PATCH -next] ASoC: Intel: sst_byt: remove kfree for memory allocated with devm_kzalloc weiyj_lk
2015-04-16 14:05 ` Jarkko Nikula [this message]
2015-04-17 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552FC1AD.7030207@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=weiyj_lk@163.com \
--cc=yang.jie@intel.com \
--cc=yao.jin@linux.intel.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox