From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: weiyj_lk@163.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.de, dan.carpenter@oracle.com,
pawel.piskorski@intel.com, yang.jie@intel.com, han.lu@intel.com
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc
Date: Thu, 16 Apr 2015 17:08:40 +0300 [thread overview]
Message-ID: <552FC268.2020503@linux.intel.com> (raw)
In-Reply-To: <1429191978-25839-1-git-send-email-weiyj_lk@163.com>
On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/intel/haswell/sst-haswell-ipc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
> index 344a1e9..324eceb 100644
> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c
> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
> @@ -2201,7 +2201,6 @@ dma_err:
> dsp_new_err:
> sst_ipc_fini(ipc);
> ipc_init_err:
> - kfree(hsw);
> return ret;
> }
> EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
>
Similar case than with baytrail. Here introduced by commit 0e7921e9583b
("ASoC: Intel: Use the generic IPC/mailbox APIs in Broadwell")
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2015-04-16 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 13:46 [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc weiyj_lk
2015-04-16 14:08 ` Jarkko Nikula [this message]
2015-04-16 21:34 ` [alsa-devel] " Jin, Yao
2015-04-17 13:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552FC268.2020503@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=han.lu@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.piskorski@intel.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=weiyj_lk@163.com \
--cc=yang.jie@intel.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox