From: Rik van Riel <riel@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tavis Ormandy <taviso@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/fpu: Load xsave pointer *after* initialization
Date: Thu, 16 Apr 2015 14:14:49 -0400 [thread overview]
Message-ID: <552FFC19.8030007@redhat.com> (raw)
In-Reply-To: <1429207509-1717-1-git-send-email-bp@alien8.de>
On 04/16/2015 02:05 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> So I was playing with gdb today and did this simple thing:
>
> gdb /bin/ls
>
> ...
>
> (gdb) run
>
> Box exploded with the splat at the end because we do cache
> &target->thread.fpu.state->xsave into the local variable xsave but
> that pointer is NULL at that time and it gets initialized later, in
> init_fpu(), see
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Tavis Ormandy <taviso@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2015-04-16 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 18:05 [PATCH] x86/fpu: Load xsave pointer *after* initialization Borislav Petkov
2015-04-16 18:14 ` Rik van Riel [this message]
2015-04-16 18:20 ` Oleg Nesterov
2015-04-16 18:31 ` Borislav Petkov
2015-04-16 18:41 ` [PATCH -v1.1] " Borislav Petkov
2015-04-17 13:06 ` Oleg Nesterov
2015-04-18 10:14 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552FFC19.8030007@redhat.com \
--to=riel@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=taviso@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox