From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbbDQCFY (ORCPT ); Thu, 16 Apr 2015 22:05:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33291 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbbDQCFP (ORCPT ); Thu, 16 Apr 2015 22:05:15 -0400 Message-ID: <55306A57.4060701@roeck-us.net> Date: Thu, 16 Apr 2015 19:05:11 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: "David S. Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state References: <1429161162-2028-1-git-send-email-linux@roeck-us.net> <552FBD4C.4070405@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.55306A5A.0174,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2015 11:51 AM, Geert Uytterhoeven wrote: > On Thu, Apr 16, 2015 at 3:46 PM, Guenter Roeck wrote: >> On 04/15/2015 10:12 PM, Guenter Roeck wrote: >>> >>> Return correct error code if _mv88e6xxx_reg_read returns an error. >>> >>> Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging >>> support") >>> Signed-off-by: Guenter Roeck >> >> >> I should have given proper credit. >> >> Reported-by: kbuild test robot >> >> For the curious, neither W=1, W=2, C-1, C=2, nor sparse report this problem, >> at least not with gcc 4.9.1. > > Good old gcc 4.1.2 (which I still use for m68k builds, and won't retire anytime > soon as it finds real bugs in every new kernel release) says: > > drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_set_port_state’: > drivers/net/dsa/mv88e6xxx.c:905: warning: ‘ret’ may be used > uninitialized in this function > > Even after your patch, as it missed one case (patch sent). > Grumble. So much for trusting tools :-( Thanks for fixing this! Guenter