From: Jens Axboe <axboe@fb.com>
To: Guenter Roeck <linux@roeck-us.net>, <linux-kernel@vger.kernel.org>
Cc: Chong Yuan <chong.yuan@memblaze.com>,
Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: Upstream kernel fails to run on qemu-sparc64 due to commit 889fa31f0 (blk-mq: reduce unnecessary software queue looping)
Date: Fri, 17 Apr 2015 08:26:11 -0600 [thread overview]
Message-ID: <55311803.9030105@fb.com> (raw)
In-Reply-To: <20150417133204.GA29300@roeck-us.net>
On 04/17/2015 07:32 AM, Guenter Roeck wrote:
> On Thu, Apr 16, 2015 at 11:32:20PM -0700, Guenter Roeck wrote:
>> Hi,
>>
>> my qemu-sparc64 tests fail to run with kernel v4.0-7245-ga39ef1a7c609.
>> Bisect points to commit 889fa31f00b ("blk-mq: reduce unnecessary software
>> queue looping"). Reverting this commit fixes the problem.
>>
>> I had a look into the commit, but I have no idea what might be wrong.
>>
>> I made the bisect log, images, configuration file, root file system, and directions
>> on how to run the images available at https://urldefense.proofpoint.com/v1/url?u=http://server.roeck-us.net/qemu/sparc64&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=%2FUVX9MC8j8RmqOwlL6HnyBe%2FFSO5xSJdG3GTTzADFYk%3D%0A&s=caaf39bb4246d5223f9dea93771fdb075f9046b6fdf1822b7da21d7665da71d5.
>>
>> Please let me know if there is any other information I can provide.
>>
> As additional information:
>
> + * Set the map size to the number of mapped software queues.
> + * This is more accurate and more efficient than looping
> + * over all possibly mapped software queues.
> + */
> + map->map_size = hctx->nr_ctx / map->bits_per_word;
>
> On my system, hctx->nr_ctx is 1, and map->bits_per_word is 8.
> Thus map->map_size is set to 0, which doesn't make much sense.
> The system comes up if I replace the above code with
> map->map_size = DIV_ROUND_UP(hctx->nr_ctx, map->bits_per_word);
>
> I have no idea if that is the correct fix, though.
Ugh, yes indeed, looks like the <= was lost from a previous patch. Now I
wonder why it I didn't see any hangs with this... Thanks for reporting,
I'll get a fix in today.
--
Jens Axboe
next prev parent reply other threads:[~2015-04-17 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 6:32 Upstream kernel fails to run on qemu-sparc64 due to commit 889fa31f0 (blk-mq: reduce unnecessary software queue looping) Guenter Roeck
2015-04-17 13:32 ` Guenter Roeck
2015-04-17 14:26 ` Jens Axboe [this message]
2015-04-17 15:31 ` Guenter Roeck
2015-04-17 15:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55311803.9030105@fb.com \
--to=axboe@fb.com \
--cc=chong.yuan@memblaze.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wenbo.wang@memblaze.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox